From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Pali Rohár" <pali.rohar@gmail.com>
Cc: Ming Lei <ming.lei@canonical.com>,
"John W. Linville" <linville@tuxdriver.com>,
Grazvydas Ignotas <notasas@gmail.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
Network Development <netdev@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Pavel Machek <pavel@ucw.cz>,
Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>,
Aaro Koskinen <aaro.koskinen@iki.fi>,
Kalle Valo <kvalo@adurom.com>, Sebastian Reichel <sre@ring0.de>,
David Gnedt <david.gnedt@davizone.at>
Subject: Re: wl1251: NVS firmware data
Date: Thu, 27 Nov 2014 07:16:55 -0800 [thread overview]
Message-ID: <20141127151655.GB23064@kroah.com> (raw)
In-Reply-To: <201411271543.23527@pali>
On Thu, Nov 27, 2014 at 03:43:23PM +0100, Pali Rohár wrote:
> On Thursday 27 November 2014 15:21:44 Ming Lei wrote:
> > On Thu, Nov 27, 2014 at 10:06 PM, Pali Rohár
> <pali.rohar@gmail.com> wrote:
> > > Hello,
> > >
> > > wifi driver wl1251 needs NVS calibration data for working.
> > > These data are loaded by driver via request_firmware from
> > > userspace file: ti-connectivity/wl1251-nvs.bin. In
> > > linux-fimrware git tree there is generic wl1251-nvs.bin
> > > file which is used by default.
> > >
> > > Driver wl1251 is used on Nokia N900 cellphone for its wifi
> > > chip. This cellphone has one special MTD partition (called
> > > CAL) where are stored some configuration data in special
> > > binary (key-value) format. And there is also stored correct
> > > calibration data for specific device (each device has
> > > different data). It is preferred to use those data instead
> > > generic one (provided by linux-firmware git tree).
> > >
> > > Now my question is: How to correctly load calibration data
> > > from special Nokia N900 CAL partition into wl1251 kernel
> > > driver?
> >
> > It is better to let user space script handle the request.
> >
>
> Yes, this makes sense. Implementing CAL parser in kernel wl1251
> driver would be hard...
>
> > > By default kernel reads ti-connectivity/wl1251-nvs.bin file
> > > from VFS if exists without any userspace support. If it
> > > fails then it fallback to loading via udev.
> >
> > You can remove or rename this file so that loading from user
> > space can be triggered.
> >
>
> It is no so easy... In case when CAL does not contains NVS data
> then we want to use this generic NVS file. And telling everybody
> to rename this is file is not good solution...
But that's up to your system configuration, not the kernel. Make a
userspace package for the firmware that creates it in the format you
need it to be in, for the hardware you have, and then there would not be
any need for a kernel change, right?
greg k-h
next prev parent reply other threads:[~2014-11-27 15:18 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-27 14:06 wl1251: NVS firmware data Pali Rohár
2014-11-27 14:21 ` Ming Lei
2014-11-27 14:43 ` Pali Rohár
2014-11-27 15:13 ` Ming Lei
2014-12-06 13:00 ` Pali Rohár
2014-11-27 15:14 ` Greg Kroah-Hartman
2014-11-27 15:24 ` Pali Rohár
2014-11-27 15:34 ` Ming Lei
2014-11-27 15:16 ` Greg Kroah-Hartman [this message]
2014-11-27 15:22 ` Pali Rohár
2014-11-27 15:58 ` Greg Kroah-Hartman
2014-12-06 12:49 ` Pavel Machek
2014-12-06 13:02 ` Pali Rohár
2014-12-08 15:18 ` Ming Lei
2014-12-08 15:22 ` Pali Rohár
2014-12-08 15:35 ` Ming Lei
2014-12-08 16:37 ` Greg Kroah-Hartman
2014-12-08 16:47 ` Pali Rohár
2014-12-08 17:05 ` Marcel Holtmann
2014-12-08 17:11 ` Pali Rohár
2014-12-08 18:50 ` Marcel Holtmann
2014-12-08 19:15 ` Pali Rohár
2014-12-08 19:26 ` Dan Williams
2014-12-08 19:36 ` Pali Rohár
2014-12-08 19:46 ` Marcel Holtmann
2014-12-08 19:56 ` Pali Rohár
2014-12-08 22:51 ` Dan Williams
2014-12-08 23:23 ` Pali Rohár
2014-12-08 23:42 ` Dan Williams
2014-12-08 23:52 ` Pali Rohár
2014-12-08 19:42 ` Ivaylo Dimitrov
2014-12-08 22:41 ` Dan Williams
2014-12-09 5:10 ` Marcel Holtmann
2014-12-08 19:41 ` Marcel Holtmann
2014-12-08 19:52 ` Pali Rohár
2014-12-08 21:00 ` Greg Kroah-Hartman
2014-12-08 21:08 ` Pali Rohár
2014-12-08 20:57 ` Greg Kroah-Hartman
2014-12-08 21:11 ` Pali Rohár
2014-12-08 23:27 ` Pali Rohár
2014-12-09 5:25 ` Marcel Holtmann
2014-12-09 0:48 ` Ming Lei
2014-12-09 4:08 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141127151655.GB23064@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=aaro.koskinen@iki.fi \
--cc=david.gnedt@davizone.at \
--cc=ivo.g.dimitrov.75@gmail.com \
--cc=kvalo@adurom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=ming.lei@canonical.com \
--cc=netdev@vger.kernel.org \
--cc=notasas@gmail.com \
--cc=pali.rohar@gmail.com \
--cc=pavel@ucw.cz \
--cc=sre@ring0.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).