Linux wireless drivers development
 help / color / mirror / Atom feed
From: "Luis R. Rodriguez" <mcgrof@suse.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Arik Nemtsov <arik@wizery.com>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH v5 2/4] cfg80211: allow usermode to query wiphy specific regdom
Date: Fri, 28 Nov 2014 23:00:20 +0100	[thread overview]
Message-ID: <20141128220020.GX25677@wotan.suse.de> (raw)
In-Reply-To: <1417182387.27562.8.camel@sipsolutions.net>

On Fri, Nov 28, 2014 at 02:46:27PM +0100, Johannes Berg wrote:
> On Thu, 2014-11-27 at 09:44 +0200, Arik Nemtsov wrote:
> > If a wiphy-idx is specified, the kernel will return the wiphy specific
> > regdomain, if such exists. Otherwise return the global regdom.
> > 
> > When no wiphy-idx is specified, return the global regdomain as well as
> > all wiphy-specific regulatory domains in the system, via a new nested
> > list of attributes.
> 
> Is that really a good idea? Seems rather easy to overrun the message
> size with that, in which case your current code will not return anything
> at all... that'll cause strange errors if somebody plugs in a few
> devices or has hwsim open as well or so ...

Good point, perhaps require 'iw reg get --all' for all listing then?
This would mean requiring an new optional flag passed on reg get too
then.

> > Add a new attribute for each wiphy-specific regdomain, for usermode to
> > identify it as such.
> 
> Shouldn't userspace also *request* this for backward compatibility?
> Otherwise older userspace might assume that a returned regd applies to
> everything, when it doesn't really?

If the flag --all is used and passed then I see no issue.

  Luis

  reply	other threads:[~2014-11-28 22:00 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-27  7:44 [PATCH v5 1/4] cfg80211: leave invalid channels on regdomain change Arik Nemtsov
2014-11-27  7:44 ` [PATCH v5 2/4] cfg80211: allow usermode to query wiphy specific regdom Arik Nemtsov
2014-11-28 13:46   ` Johannes Berg
2014-11-28 22:00     ` Luis R. Rodriguez [this message]
2014-11-30 12:26       ` Arik Nemtsov
2014-11-30 12:32         ` Johannes Berg
2014-11-30 12:36           ` Arik Nemtsov
2014-11-28 22:03   ` Luis R. Rodriguez
2014-11-27  7:44 ` [PATCH v5 3/4] cfg80211: allow wiphy specific regdomain management Arik Nemtsov
2014-11-28 13:53   ` Johannes Berg
2014-11-27  7:44 ` [PATCH v5 4/4] cfg80211: return private regdom for self-managed devices Arik Nemtsov
2014-11-28 13:57   ` Johannes Berg
2014-11-28 13:44 ` [PATCH v5 1/4] cfg80211: leave invalid channels on regdomain change Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141128220020.GX25677@wotan.suse.de \
    --to=mcgrof@suse.com \
    --cc=arik@wizery.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox