* Re: [PATCH] drivers:net:wireless: Add proper locking for the function, b43_op_beacon_set_tim in main.c
[not found] <1420184041-6788-1-git-send-email-xerofoify@gmail.com>
@ 2015-01-02 9:27 ` Michael Büsch
2015-01-02 11:19 ` Rafał Miłecki
2015-01-02 16:40 ` Larry Finger
2015-01-05 9:29 ` Kalle Valo
2 siblings, 1 reply; 6+ messages in thread
From: Michael Büsch @ 2015-01-02 9:27 UTC (permalink / raw)
To: Nicholas Krause
Cc: stefano.brivio, netdev, linux-wireless, b43-dev, kvalo,
linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1387 bytes --]
On Fri, 2 Jan 2015 02:34:01 -0500
Nicholas Krause <xerofoify@gmail.com> wrote:
> This adds proper locking for the function, b43_op_beacon_set_tim in main.c by using the mutex lock
> in the structure pointer wl, as embedded into this pointer as a mutex in order to protect against
> multiple access to the pointer wl when updating the templates for this pointer in the function,
> b43_update_templates internally in the function, b43_op_beacon_set_tim.
>
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> ---
> drivers/net/wireless/b43/main.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/b43/main.c b/drivers/net/wireless/b43/main.c
> index 47731cb..d568fc8 100644
> --- a/drivers/net/wireless/b43/main.c
> +++ b/drivers/net/wireless/b43/main.c
> @@ -5094,8 +5094,9 @@ static int b43_op_beacon_set_tim(struct ieee80211_hw *hw,
> {
> struct b43_wl *wl = hw_to_b43_wl(hw);
>
> - /* FIXME: add locking */
> + mutex_lock(&wl->mutex);
> b43_update_templates(wl);
> + mutex_unlock(&wl->mutex);
>
> return 0;
> }
Thanks for the patch.
However, this does not work. We are in atomic context here.
Please see the b43-dev mailing list archives for a recent thread about that.
I'm also pretty sure that this is safe without lock, due to the higher level locks in mac80211.
--
Michael
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] drivers:net:wireless: Add proper locking for the function, b43_op_beacon_set_tim in main.c
2015-01-02 9:27 ` [PATCH] drivers:net:wireless: Add proper locking for the function, b43_op_beacon_set_tim in main.c Michael Büsch
@ 2015-01-02 11:19 ` Rafał Miłecki
2015-01-02 11:42 ` Michael Büsch
0 siblings, 1 reply; 6+ messages in thread
From: Rafał Miłecki @ 2015-01-02 11:19 UTC (permalink / raw)
To: Michael Büsch
Cc: Nicholas Krause, Stefano Brivio, Network Development,
linux-wireless@vger.kernel.org, Linux Kernel Mailing List,
b43-dev, Kalle Valo
On 2 January 2015 at 10:27, Michael Büsch <m@bues.ch> wrote:
> On Fri, 2 Jan 2015 02:34:01 -0500
> Nicholas Krause <xerofoify@gmail.com> wrote:
>
>> This adds proper locking for the function, b43_op_beacon_set_tim in main.c by using the mutex lock
>> in the structure pointer wl, as embedded into this pointer as a mutex in order to protect against
>> multiple access to the pointer wl when updating the templates for this pointer in the function,
>> b43_update_templates internally in the function, b43_op_beacon_set_tim.
>>
>> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
>> ---
>> drivers/net/wireless/b43/main.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/wireless/b43/main.c b/drivers/net/wireless/b43/main.c
>> index 47731cb..d568fc8 100644
>> --- a/drivers/net/wireless/b43/main.c
>> +++ b/drivers/net/wireless/b43/main.c
>> @@ -5094,8 +5094,9 @@ static int b43_op_beacon_set_tim(struct ieee80211_hw *hw,
>> {
>> struct b43_wl *wl = hw_to_b43_wl(hw);
>>
>> - /* FIXME: add locking */
>> + mutex_lock(&wl->mutex);
>> b43_update_templates(wl);
>> + mutex_unlock(&wl->mutex);
>>
>> return 0;
>> }
>
> Thanks for the patch.
>
> However, this does not work. We are in atomic context here.
> Please see the b43-dev mailing list archives for a recent thread about that.
Michael: guess who it was who sent the patch doing the same back in November.
Yes, the same troll.
--
Rafał
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] drivers:net:wireless: Add proper locking for the function, b43_op_beacon_set_tim in main.c
2015-01-02 11:19 ` Rafał Miłecki
@ 2015-01-02 11:42 ` Michael Büsch
0 siblings, 0 replies; 6+ messages in thread
From: Michael Büsch @ 2015-01-02 11:42 UTC (permalink / raw)
To: Rafał Miłecki
Cc: Nicholas Krause, Stefano Brivio, Network Development,
linux-wireless@vger.kernel.org, Linux Kernel Mailing List,
b43-dev, Kalle Valo
[-- Attachment #1: Type: text/plain, Size: 1703 bytes --]
On Fri, 2 Jan 2015 12:19:12 +0100
Rafał Miłecki <zajec5@gmail.com> wrote:
> On 2 January 2015 at 10:27, Michael Büsch <m@bues.ch> wrote:
> > On Fri, 2 Jan 2015 02:34:01 -0500
> > Nicholas Krause <xerofoify@gmail.com> wrote:
> >
> >> This adds proper locking for the function, b43_op_beacon_set_tim in main.c by using the mutex lock
> >> in the structure pointer wl, as embedded into this pointer as a mutex in order to protect against
> >> multiple access to the pointer wl when updating the templates for this pointer in the function,
> >> b43_update_templates internally in the function, b43_op_beacon_set_tim.
> >>
> >> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> >> ---
> >> drivers/net/wireless/b43/main.c | 3 ++-
> >> 1 file changed, 2 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/net/wireless/b43/main.c b/drivers/net/wireless/b43/main.c
> >> index 47731cb..d568fc8 100644
> >> --- a/drivers/net/wireless/b43/main.c
> >> +++ b/drivers/net/wireless/b43/main.c
> >> @@ -5094,8 +5094,9 @@ static int b43_op_beacon_set_tim(struct ieee80211_hw *hw,
> >> {
> >> struct b43_wl *wl = hw_to_b43_wl(hw);
> >>
> >> - /* FIXME: add locking */
> >> + mutex_lock(&wl->mutex);
> >> b43_update_templates(wl);
> >> + mutex_unlock(&wl->mutex);
> >>
> >> return 0;
> >> }
> >
> > Thanks for the patch.
> >
> > However, this does not work. We are in atomic context here.
> > Please see the b43-dev mailing list archives for a recent thread about that.
>
> Michael: guess who it was who sent the patch doing the same back in November.
>
> Yes, the same troll.
D'oh.
Thanks for the notice.
--
Michael
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drivers:net:wireless: Add proper locking for the function, b43_op_beacon_set_tim in main.c
[not found] <1420184041-6788-1-git-send-email-xerofoify@gmail.com>
2015-01-02 9:27 ` [PATCH] drivers:net:wireless: Add proper locking for the function, b43_op_beacon_set_tim in main.c Michael Büsch
@ 2015-01-02 16:40 ` Larry Finger
2015-01-05 9:29 ` Kalle Valo
2 siblings, 0 replies; 6+ messages in thread
From: Larry Finger @ 2015-01-02 16:40 UTC (permalink / raw)
To: Nicholas Krause, stefano.brivio
Cc: netdev, linux-wireless, b43-dev, kvalo, linux-kernel
On 01/02/2015 01:34 AM, Nicholas Krause wrote:
> This adds proper locking for the function, b43_op_beacon_set_tim in main.c by using the mutex lock
> in the structure pointer wl, as embedded into this pointer as a mutex in order to protect against
> multiple access to the pointer wl when updating the templates for this pointer in the function,
> b43_update_templates internally in the function, b43_op_beacon_set_tim.
>
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
Although this patch has already been rejected, I want to comment on the subject
you have chosen. As you are submitting it to the maintainer of
drivers/net/wireless/, there is no need to place those entities in the subject.
A better subject would have been "b43: Add proper locking for
b43_op_beacon_set_tim()".
Larry
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] drivers:net:wireless: Add proper locking for the function, b43_op_beacon_set_tim in main.c
[not found] <1420184041-6788-1-git-send-email-xerofoify@gmail.com>
2015-01-02 9:27 ` [PATCH] drivers:net:wireless: Add proper locking for the function, b43_op_beacon_set_tim in main.c Michael Büsch
2015-01-02 16:40 ` Larry Finger
@ 2015-01-05 9:29 ` Kalle Valo
[not found] ` <54AAC6EE.2000603@gmail.com>
2 siblings, 1 reply; 6+ messages in thread
From: Kalle Valo @ 2015-01-05 9:29 UTC (permalink / raw)
To: Nicholas Krause
Cc: stefano.brivio, linux-wireless, b43-dev, netdev, linux-kernel
Nicholas Krause <xerofoify@gmail.com> writes:
> This adds proper locking for the function, b43_op_beacon_set_tim in
> main.c by using the mutex lock in the structure pointer wl, as
> embedded into this pointer as a mutex in order to protect against
> multiple access to the pointer wl when updating the templates for this
> pointer in the function, b43_update_templates internally in the
> function, b43_op_beacon_set_tim.
>
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
Based on the discussion I have dropped this patch.
--
Kalle Valo
^ permalink raw reply [flat|nested] 6+ messages in thread