linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bob Copeland <me@bobcopeland.com>
To: Masashi Honma <masashi.honma@gmail.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] mesh: Skip STA expiration on user_mpm mode
Date: Fri, 16 Jan 2015 07:59:57 -0500	[thread overview]
Message-ID: <20150116125957.GA10300@localhost> (raw)
In-Reply-To: <CAFk-A4ko5S_+SFNk8RWvrWJ9k-kEQnqKCEKrTZs0GrZ9QScMJA@mail.gmail.com>

On Fri, Jan 16, 2015 at 11:04:30AM +0900, Masashi Honma wrote:
> 2015-01-15 12:14 GMT+09:00 Bob Copeland <me@bobcopeland.com>:
> > I took a look at what authsae is doing, and it looks like it's just
> > prepared to handle the NL80211_CMD_DEL_STATION events generated from
> > cfg80211_del_sta() -- is there a reason that couldn't work for wpa_s
> > too?  Then you'd only need the patch to configure that timeout on the
> > client, and you can simplify it by not caring about user_mpm.
> 
> Thank you for your review.
> 
> Indeed wpa_supplicant do nothing even if it receivced NL80211_CMD_DEL_STATION.
> But the mismatch (wpa_supplicant recognizes STA is alive, mac80211
> recognizes STA leaved) is not so good.

Right - so wpa_s could be changed to handle this event (for mesh),
I think.

> Anyway I have not considered authsae user land application.
> Does authsae have it's own inactivity timer ?
> If not, I will drop this patch.

No, it relies on mac80211's inactivity timer.  So, yeah, I think this
patch would break authsae, in the sense that stations would never
get removed.

-- 
Bob Copeland %% http://bobcopeland.com/

  reply	other threads:[~2015-01-16 13:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-14  2:23 [PATCH] mesh: Skip STA expiration on user_mpm mode Masashi Honma
2015-01-15  3:14 ` Bob Copeland
2015-01-16  2:04   ` Masashi Honma
2015-01-16 12:59     ` Bob Copeland [this message]
2015-01-18 23:33       ` Masashi Honma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150116125957.GA10300@localhost \
    --to=me@bobcopeland.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=masashi.honma@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).