From: Bob Copeland <me@bobcopeland.com>
To: Masashi Honma <masashi.honma@gmail.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2] mac80211: Avoid STA expiration timer truncation to u32
Date: Fri, 16 Jan 2015 08:31:52 -0500 [thread overview]
Message-ID: <20150116133152.GC10300@localhost> (raw)
In-Reply-To: <1421389121-2841-1-git-send-email-masashi.honma@gmail.com>
On Fri, Jan 16, 2015 at 03:18:41PM +0900, Masashi Honma wrote:
> On some combination of plink_timeout and HZ, the STA expiration timer will be
> unexpectedly truncated to u32. Maybe there is a question "Who sets such a large
Nice catch!
> - ieee80211_sta_expire(sdata, ifmsh->mshcfg.plink_timeout * HZ);
> + ieee80211_sta_expire(sdata, ifmsh->mshcfg.plink_timeout *
> + (unsigned long)HZ);
There's a remaining problem on 32-bit platforms: there, unsigned long
is 32 bits so 0xffffffff * HZ will still truncate to 32 bits.
For normal values of HZ though, result will still be 'a rather large
number,' so maybe it's not worth caring about that.
--
Bob Copeland %% http://bobcopeland.com/
next prev parent reply other threads:[~2015-01-16 13:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-16 5:17 [PATCH] mesh: Avoid STA expiration timer truncation to u32 Masashi Honma
2015-01-16 5:49 ` Kalle Valo
2015-01-16 6:12 ` Masashi Honma
2015-01-16 6:18 ` [PATCH v2] mac80211: " Masashi Honma
2015-01-16 13:31 ` Bob Copeland [this message]
2015-01-20 2:44 ` Masashi Honma
2015-01-20 2:47 ` [PATCH v3] " Masashi Honma
2015-01-23 9:42 ` Johannes Berg
2015-01-23 14:27 ` Masashi Honma
2015-02-04 2:22 ` [PATCH v4] mac80211: Allow 0 for NL80211_MESHCONF_PLINK_TIMEOUT to disable STA expiration Masashi Honma
2015-02-24 9:46 ` Johannes Berg
[not found] ` <CAFk-A4nyEvsaCah97ohnbLW7a0+GRbnuJGLyFkBLbpWVffn85w@mail.gmail.com>
2015-02-24 10:03 ` Fwd: " Masashi Honma
2015-02-24 13:42 ` [PATCH v5] " Masashi Honma
2015-02-24 20:08 ` Johannes Berg
2015-02-24 23:24 ` Masashi Honma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150116133152.GC10300@localhost \
--to=me@bobcopeland.com \
--cc=linux-wireless@vger.kernel.org \
--cc=masashi.honma@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).