From: James Cameron <quozl@laptop.org>
To: Avinash Patil <patila@marvell.com>
Cc: linux-wireless@vger.kernel.org, akarwar@marvell.com,
cluo@marvell.com, yogeshp@marvell.com, nishants@marvell.com,
frankh@marvell.com
Subject: Re: [PATCH 3/3] mwifiex: selectively choose ext_scan support
Date: Thu, 22 Jan 2015 07:11:01 +1100 [thread overview]
Message-ID: <20150121201101.GA5472@us.netrek.org> (raw)
In-Reply-To: <1421858531-4536-3-git-send-email-patila@marvell.com>
On Wed, Jan 21, 2015 at 10:12:11PM +0530, Avinash Patil wrote:
> @@ -256,6 +256,7 @@ struct sdio_mmc_card {
>
> u8 *mp_regs;
> u8 auto_tdls;
> + u8 ext_scan;
Why not same name as below?
> @@ -273,6 +274,7 @@ struct mwifiex_sdio_device {
> u32 mp_tx_agg_buf_size;
> u32 mp_rx_agg_buf_size;
> u8 auto_tdls;
> + u8 ext_scan_support;
> @@ -206,6 +206,7 @@ struct mwifiex_pcie_device {
> u16 blksz_fw_dl;
> u16 tx_buf_size;
> bool supports_fw_dump;
> + u8 ext_scan_support;
Not consistent name style with other support variable above. Perhaps
should be support_ext_scan.
Long variable names for all support variables, perhaps should use:
- supports_sdio_new_mode
+ can_sdio_new
- supports_fw_dump
+ can_dump
- supports_ext_scan
+ can_ext_scan
--
James Cameron
http://quozl.linux.org.au/
next prev parent reply other threads:[~2015-01-21 20:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-21 16:42 [PATCH 1/3] mwifiex: add support for SD8801 Avinash Patil
2015-01-21 16:42 ` [PATCH 2/3] mwifiex: add support for USB8801 Avinash Patil
2015-01-21 16:42 ` [PATCH 3/3] mwifiex: selectively choose ext_scan support Avinash Patil
2015-01-21 16:35 ` Johannes Berg
2015-01-21 16:36 ` Johannes Berg
2015-01-23 10:41 ` Avinash Patil
2015-01-21 20:11 ` James Cameron [this message]
2015-01-23 10:21 ` Avinash Patil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150121201101.GA5472@us.netrek.org \
--to=quozl@laptop.org \
--cc=akarwar@marvell.com \
--cc=cluo@marvell.com \
--cc=frankh@marvell.com \
--cc=linux-wireless@vger.kernel.org \
--cc=nishants@marvell.com \
--cc=patila@marvell.com \
--cc=yogeshp@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).