* [PATCH] ath9k_htc: remove dead code in error path of ath9k_htc_txcompletion_cb
@ 2015-01-19 19:02 John W. Linville
2015-01-23 19:16 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: John W. Linville @ 2015-01-19 19:02 UTC (permalink / raw)
To: linux-wireless
Cc: Kalle Valo, QCA ath9k Development, ath9k-devel, John W. Linville
This clause is conditioned on htc_hdr != NULL, but it will only be NULL
when that check is reached.
Coverity: CID 114318
Signed-off-by: John W. Linville <linville@tuxdriver.com>
---
drivers/net/wireless/ath/ath9k/htc_hst.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/net/wireless/ath/ath9k/htc_hst.c b/drivers/net/wireless/ath/ath9k/htc_hst.c
index a0ff5b637054..d2408da38c1c 100644
--- a/drivers/net/wireless/ath/ath9k/htc_hst.c
+++ b/drivers/net/wireless/ath/ath9k/htc_hst.c
@@ -351,11 +351,7 @@ void ath9k_htc_txcompletion_cb(struct htc_target *htc_handle,
return;
ret:
- /* HTC-generated packets are freed here. */
- if (htc_hdr && htc_hdr->endpoint_id != ENDPOINT0)
- dev_kfree_skb_any(skb);
- else
- kfree_skb(skb);
+ kfree_skb(skb);
}
static void ath9k_htc_fw_panic_report(struct htc_target *htc_handle,
--
2.1.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: ath9k_htc: remove dead code in error path of ath9k_htc_txcompletion_cb
2015-01-19 19:02 [PATCH] ath9k_htc: remove dead code in error path of ath9k_htc_txcompletion_cb John W. Linville
@ 2015-01-23 19:16 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2015-01-23 19:16 UTC (permalink / raw)
To: John Linville
Cc: linux-wireless, QCA ath9k Development, ath9k-devel,
John W. Linville
> This clause is conditioned on htc_hdr != NULL, but it will only be NULL
> when that check is reached.
>
> Coverity: CID 114318
>
> Signed-off-by: John W. Linville <linville@tuxdriver.com>
Thanks, applied to wireless-drivers-next.git.
Kalle Valo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-01-23 19:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-19 19:02 [PATCH] ath9k_htc: remove dead code in error path of ath9k_htc_txcompletion_cb John W. Linville
2015-01-23 19:16 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).