From: "Jakub Kiciński" <moorray3@wp.pl>
To: Peter Oh <poh@qca.qualcomm.com>
Cc: <ath10k@lists.infradead.org>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v2] ath10k: Replace ioread with mb to drain write buffer
Date: Fri, 6 Feb 2015 15:53:43 +0100 [thread overview]
Message-ID: <20150206155343.5fe43aa9@north> (raw)
In-Reply-To: <20150206095846.5d46f11e@north>
On Fri, 6 Feb 2015 09:58:46 +0100, Jakub Kiciński wrote:
> On Fri, 30 Jan 2015 16:14:30 -0800, Peter Oh wrote:
> > Using ioread() to perform draining write buffer is excessive.
> > Use compact API, mb(), that intended to be used for the case.
> > It reduces total 14 CPU clocks per interrupt.
> >
> > Signed-off-by: Peter Oh <poh@qca.qualcomm.com>
>
> I have no idea what the code does but this change looks suspicious.
> Usually the point of ioread() is to flush the interconnect buffers
> while mb() ensures ordering only from the CPU perspective.
>
> Could you provide the reason *why* flushing buffers is unnecessary
> in the commit message?
I just noticed the discussion on the first version of the patch.
Sorry about the noise.
prev parent reply other threads:[~2015-02-06 14:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-31 0:14 [PATCH v2] ath10k: Replace ioread with mb to drain write buffer Peter Oh
2015-02-06 8:58 ` Jakub Kiciński
2015-02-06 14:53 ` Jakub Kiciński [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150206155343.5fe43aa9@north \
--to=moorray3@wp.pl \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=poh@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).