From: Mark Rutland <mark.rutland@arm.com>
To: Eliad Peller <eliad@wizery.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Ido Yariv <ido@wizery.com>
Subject: Re: [PATCH v2] wlcore: add basic device-tree support
Date: Tue, 17 Feb 2015 15:48:55 +0000 [thread overview]
Message-ID: <20150217154855.GQ8994@leverpostej> (raw)
In-Reply-To: <1423998550-8829-1-git-send-email-eliad@wizery.com>
[...]
> + wlcore: wlcore@0 {
> + compatible = "ti,wlcore";
> + reg = <2>;
Nit: the reg and unit-address (the bit after the '@' in the node name)
should match.
Mark.
next prev parent reply other threads:[~2015-02-17 15:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-15 11:09 [PATCH v2] wlcore: add basic device-tree support Eliad Peller
2015-02-16 10:06 ` Arnd Bergmann
2015-02-17 15:39 ` Eliad Peller
2015-02-17 15:45 ` Mark Rutland
2015-02-18 8:14 ` Eliad Peller
2015-02-17 15:48 ` Mark Rutland [this message]
2015-02-27 7:31 ` Luca Coelho
2015-03-08 11:04 ` Eliad Peller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150217154855.GQ8994@leverpostej \
--to=mark.rutland@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=eliad@wizery.com \
--cc=ido@wizery.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox