* [patch] rtlwifi: rtl8188ee: missing curly braces in handle_branch1()
@ 2015-02-25 13:24 Dan Carpenter
2015-02-25 16:34 ` Larry Finger
2015-03-03 13:42 ` Kalle Valo
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2015-02-25 13:24 UTC (permalink / raw)
To: Larry Finger
Cc: Chaoming Li, Kalle Valo, John W. Linville, linux-wireless,
kernel-janitors
>From the indenting, it seems like the READ_NEXT_PAIR() was supposed to
be inside the while loop.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/wireless/rtlwifi/rtl8188ee/phy.c b/drivers/net/wireless/rtlwifi/rtl8188ee/phy.c
index 3f6c59c..a2bb02c 100644
--- a/drivers/net/wireless/rtlwifi/rtl8188ee/phy.c
+++ b/drivers/net/wireless/rtlwifi/rtl8188ee/phy.c
@@ -452,9 +452,10 @@ static void handle_branch1(struct ieee80211_hw *hw, u16 arraylen,
READ_NEXT_PAIR(v1, v2, i);
while (v2 != 0xDEAD &&
v2 != 0xCDEF &&
- v2 != 0xCDCD && i < arraylen - 2)
+ v2 != 0xCDCD && i < arraylen - 2) {
_rtl8188e_config_bb_reg(hw, v1, v2);
READ_NEXT_PAIR(v1, v2, i);
+ }
while (v2 != 0xDEAD && i < arraylen - 2)
READ_NEXT_PAIR(v1, v2, i);
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [patch] rtlwifi: rtl8188ee: missing curly braces in handle_branch1()
2015-02-25 13:24 [patch] rtlwifi: rtl8188ee: missing curly braces in handle_branch1() Dan Carpenter
@ 2015-02-25 16:34 ` Larry Finger
2015-03-03 13:42 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Larry Finger @ 2015-02-25 16:34 UTC (permalink / raw)
To: Dan Carpenter
Cc: Chaoming Li, Kalle Valo, John W. Linville, linux-wireless,
kernel-janitors
On 02/25/2015 07:24 AM, Dan Carpenter wrote:
>>From the indenting, it seems like the READ_NEXT_PAIR() was supposed to
> be inside the while loop.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Good catch.
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Thanks,
Larry
>
> diff --git a/drivers/net/wireless/rtlwifi/rtl8188ee/phy.c b/drivers/net/wireless/rtlwifi/rtl8188ee/phy.c
> index 3f6c59c..a2bb02c 100644
> --- a/drivers/net/wireless/rtlwifi/rtl8188ee/phy.c
> +++ b/drivers/net/wireless/rtlwifi/rtl8188ee/phy.c
> @@ -452,9 +452,10 @@ static void handle_branch1(struct ieee80211_hw *hw, u16 arraylen,
> READ_NEXT_PAIR(v1, v2, i);
> while (v2 != 0xDEAD &&
> v2 != 0xCDEF &&
> - v2 != 0xCDCD && i < arraylen - 2)
> + v2 != 0xCDCD && i < arraylen - 2) {
> _rtl8188e_config_bb_reg(hw, v1, v2);
> READ_NEXT_PAIR(v1, v2, i);
> + }
>
> while (v2 != 0xDEAD && i < arraylen - 2)
> READ_NEXT_PAIR(v1, v2, i);
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: rtlwifi: rtl8188ee: missing curly braces in handle_branch1()
2015-02-25 13:24 [patch] rtlwifi: rtl8188ee: missing curly braces in handle_branch1() Dan Carpenter
2015-02-25 16:34 ` Larry Finger
@ 2015-03-03 13:42 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2015-03-03 13:42 UTC (permalink / raw)
To: Dan Carpenter
Cc: Larry Finger, Chaoming Li, John W. Linville, linux-wireless,
kernel-janitors
> From the indenting, it seems like the READ_NEXT_PAIR() was supposed to
> be inside the while loop.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Thanks, applied to wireless-drivers-next.git.
Kalle Valo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-03-03 13:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-25 13:24 [patch] rtlwifi: rtl8188ee: missing curly braces in handle_branch1() Dan Carpenter
2015-02-25 16:34 ` Larry Finger
2015-03-03 13:42 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).