From: Mike Frysinger <vapier@gentoo.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH crda 2/4] allow people to turn off -Werror
Date: Wed, 4 Mar 2015 15:22:35 -0500 [thread overview]
Message-ID: <20150304202235.GB7320@vapier> (raw)
In-Reply-To: <1425498807.1810.14.camel@sipsolutions.net>
[-- Attachment #1: Type: text/plain, Size: 631 bytes --]
On 04 Mar 2015 20:53, Johannes Berg wrote:
> On Wed, 2015-03-04 at 14:51 -0500, Mike Frysinger wrote:
> > From: Mike Frysinger <vapier@chromium.org>
> >
> > Forcing -Werror at build time easily breaks across compiler settings,
> > compiler versions, architectures, C libraries, etc... Add a knob so
> > distro peeps can turn it off.
>
> > +WERROR = -Werror
>
> Doesn't that need ?= ?
yes, if you wanted to support:
WERROR= make
but the expectation is that you'd do:
make WERROR=
in which case this code is working as i intended. if the maintainers want to
use ?= then it doesn't matter to me.
-mike
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-03-04 20:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-04 19:51 [PATCH crda 1/4] do not run ldconfig Mike Frysinger
2015-03-04 19:51 ` [PATCH crda 2/4] allow people to turn off -Werror Mike Frysinger
2015-03-04 19:53 ` Johannes Berg
2015-03-04 20:22 ` Mike Frysinger [this message]
2015-03-04 20:31 ` Johannes Berg
2015-03-04 21:51 ` Mike Frysinger
2015-03-04 19:51 ` [PATCH crda 3/4] fix openssl generation Mike Frysinger
2015-03-04 19:51 ` [PATCH crda 4/4] clean up CFLAGS handling Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150304202235.GB7320@vapier \
--to=vapier@gentoo.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).