From: Rajkumar Manoharan <rmanohar@qti.qualcomm.com>
To: Kalle Valo <kvalo@qca.qualcomm.com>
Cc: <ath10k@lists.infradead.org>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 1/3] ath10k: add sysfs entry to configure quiet period
Date: Tue, 10 Mar 2015 22:23:24 +0530 [thread overview]
Message-ID: <20150310165323.GB11700@qca.qualcomm.com> (raw)
In-Reply-To: <87lhj4yi0x.fsf@kamboji.qca.qualcomm.com>
On Tue, Mar 10, 2015 at 05:43:58PM +0200, Kalle Valo wrote:
> Rajkumar Manoharan <rmanohar@qti.qualcomm.com> writes:
>
> > Add support to configure quiet period via sysfs entry. This will
> > be helpful to experiment different quiet period values along with
> > different duty cycle ratio.
> >
> > To configure quiet period as 30ms,
> >
> > echo 30 >/sys/class/ieee80211/phyX/device/quiet_period
>
> What's the justification? To me this looks like an ugly driver private
> hack. Why can't you use nl80211 or something else?
As this is purely for testing purpose to play around with different
quiet period along with various throttling state, sysfs entry is used
instead of netlink testmode command. Instead of debugfs, sysfs entry is
selected to align with existing thermal interface.
-Rajkumar
next prev parent reply other threads:[~2015-03-10 16:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-20 13:04 [PATCH 1/3] ath10k: add sysfs entry to configure quiet period Rajkumar Manoharan
2015-02-20 13:04 ` [PATCH 2/3] ath10k: fix wrong symlink name on error path Rajkumar Manoharan
2015-03-12 13:00 ` Kalle Valo
2015-03-15 8:24 ` Rajkumar Manoharan
2015-02-20 13:04 ` [PATCH 3/3] ath10k: add symlink for hwmon device Rajkumar Manoharan
2015-03-10 15:39 ` Kalle Valo
2015-03-10 16:42 ` Rajkumar Manoharan
2015-03-12 13:20 ` Kalle Valo
2015-03-12 13:46 ` Rajkumar Manoharan
2015-03-10 15:43 ` [PATCH 1/3] ath10k: add sysfs entry to configure quiet period Kalle Valo
2015-03-10 16:53 ` Rajkumar Manoharan [this message]
2015-03-12 13:21 ` Kalle Valo
2015-03-12 13:50 ` Rajkumar Manoharan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150310165323.GB11700@qca.qualcomm.com \
--to=rmanohar@qti.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).