[PATCH] rtlwifi: rtl8192cu: Remove unnecessary parameter

[PATCH] rtlwifi: rtl8192cu: Remove unnecessary parameter

[Taehee Yoo]

Remove unnecessary parameter in rtl8192cu/hw.c

Signed-off-by: Taehee Yoo <ap420073@gmail.com>
---
 drivers/net/wireless/rtlwifi/rtl8192cu/hw.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c b/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c
index 0c20dd7..43b2b20 100644
--- a/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c
+++ b/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c
@@ -1471,8 +1471,7 @@ static void _InitBeaconParameters(struct ieee80211_hw *hw)
 		rtl_write_word(rtlpriv, REG_BCNTCFG, 0x66FF);
 }
 
-static void _beacon_function_enable(struct ieee80211_hw *hw, bool Enable,
-				    bool Linked)
+static void _beacon_function_enable(struct ieee80211_hw *hw)
 {
 	struct rtl_priv *rtlpriv = rtl_priv(hw);
 
@@ -1517,7 +1516,7 @@ void rtl92cu_set_beacon_related_registers(struct ieee80211_hw *hw)
 		rtl_write_byte(rtlpriv, REG_RXTSF_OFFSET_CCK, 0x50);
 		rtl_write_byte(rtlpriv, REG_RXTSF_OFFSET_OFDM, 0x50);
 	}
-	_beacon_function_enable(hw, true, true);
+	_beacon_function_enable(hw);
 }
 
 void rtl92cu_set_beacon_interval(struct ieee80211_hw *hw)
-- 
1.9.1

Re: [PATCH] rtlwifi: rtl8192cu: Remove unnecessary parameter

[Larry Finger]

On 03/09/2015 10:07 AM, Taehee Yoo wrote:
> Remove unnecessary parameter in rtl8192cu/hw.c
>
> Signed-off-by: Taehee Yoo <ap420073@gmail.com>
> ---
>   drivers/net/wireless/rtlwifi/rtl8192cu/hw.c | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)

The patch is OK, but the subject is awful. When I first saw it, I thought that 
you were removing a module parameter. On inspection, I see that you are removing 
function arguments from _beacon_function_enable(). Why not say that?

Larry

>
> diff --git a/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c b/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c
> index 0c20dd7..43b2b20 100644
> --- a/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c
> +++ b/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c
> @@ -1471,8 +1471,7 @@ static void _InitBeaconParameters(struct ieee80211_hw *hw)
>   		rtl_write_word(rtlpriv, REG_BCNTCFG, 0x66FF);
>   }
>
> -static void _beacon_function_enable(struct ieee80211_hw *hw, bool Enable,
> -				    bool Linked)
> +static void _beacon_function_enable(struct ieee80211_hw *hw)
>   {
>   	struct rtl_priv *rtlpriv = rtl_priv(hw);
>
> @@ -1517,7 +1516,7 @@ void rtl92cu_set_beacon_related_registers(struct ieee80211_hw *hw)
>   		rtl_write_byte(rtlpriv, REG_RXTSF_OFFSET_CCK, 0x50);
>   		rtl_write_byte(rtlpriv, REG_RXTSF_OFFSET_OFDM, 0x50);
>   	}
> -	_beacon_function_enable(hw, true, true);
> +	_beacon_function_enable(hw);
>   }
>
>   void rtl92cu_set_beacon_interval(struct ieee80211_hw *hw)
>

Re: [PATCH] rtlwifi: rtl8192cu: Remove unnecessary parameter

[ap420073 .]

2015-03-10 0:40 GMT+09:00 Larry Finger <Larry.Finger@lwfinger.net>:
>
> On 03/09/2015 10:07 AM, Taehee Yoo wrote:
>>
>> Remove unnecessary parameter in rtl8192cu/hw.c
>>
>> Signed-off-by: Taehee Yoo <ap420073@gmail.com>
>> ---
>>   drivers/net/wireless/rtlwifi/rtl8192cu/hw.c | 5 ++---
>>   1 file changed, 2 insertions(+), 3 deletions(-)
>
>
> The patch is OK, but the subject is awful. When I first saw it, I thought that you were removing a module parameter. On inspection, I see that you are removing function arguments from _beacon_function_enable(). Why not say that?
>
> Larry
>
>
>>
>> diff --git a/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c b/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c
>> index 0c20dd7..43b2b20 100644
>> --- a/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c
>> +++ b/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c
>> @@ -1471,8 +1471,7 @@ static void _InitBeaconParameters(struct ieee80211_hw *hw)
>>                 rtl_write_word(rtlpriv, REG_BCNTCFG, 0x66FF);
>>   }
>>
>> -static void _beacon_function_enable(struct ieee80211_hw *hw, bool Enable,
>> -                                   bool Linked)
>> +static void _beacon_function_enable(struct ieee80211_hw *hw)
>>   {
>>         struct rtl_priv *rtlpriv = rtl_priv(hw);
>>
>> @@ -1517,7 +1516,7 @@ void rtl92cu_set_beacon_related_registers(struct ieee80211_hw *hw)
>>                 rtl_write_byte(rtlpriv, REG_RXTSF_OFFSET_CCK, 0x50);
>>                 rtl_write_byte(rtlpriv, REG_RXTSF_OFFSET_OFDM, 0x50);
>>         }
>> -       _beacon_function_enable(hw, true, true);
>> +       _beacon_function_enable(hw);
>>   }
>>
>>   void rtl92cu_set_beacon_interval(struct ieee80211_hw *hw)
>>
>

Apologize that i do not explain this patch.

arguments Enable, Linked is not used in _beacon_function_enable() function.

in vendor driver, that function have same arguments but this is not used.

so i removed this argument.


I think simple code is not need detailed explain.

this is my fault.

from now on i surely say that detailed patch comment.

Thanks for review.

Re: rtlwifi: rtl8192cu: remove unused arguments from _beacon_function_enable()

[Kalle Valo]

> Remove unnecessary parameter in rtl8192cu/hw.c
> 
> Signed-off-by: Taehee Yoo <ap420073@gmail.com>

Thanks, applied to wireless-drivers-next.git. I just changed the title based on
Larry's comment:

708c964c5df8 rtlwifi: rtl8192cu: remove unused arguments from _beacon_function_enable()

Kalle Valo