Re: [1/3] rt2x00usb: initialize the read value in case of failure

[Stanislaw Gruszka <sgruszka@redhat.com>]

On Thu, Mar 19, 2015 at 02:24:02PM +0100, Sebastian Andrzej Siewior wrote:
> On 03/18/2015 02:11 PM, Stanislaw Gruszka wrote:
> > On Tue, Mar 17, 2015 at 09:34:14AM +0100, Sebastian Andrzej Siewior wrote:
> >> I have no idea what AutoRun mode is (it seems that the stick already
> >> has a firmware and is happy with it) and I have no clue why the firmware
> >> decides to lie about it. I looked at the vendor driver I found at github
> >> (which seems to be from 2012-10-22, DPO_RT5572_LinuxSTA_2.6.1.3) and
> >> well, I look again if someone says it is worth looking… They seem to do
> >> some kind "firmware is comming" magic which might be already done in the
> >> current driver at a different spot but I think the main question is why
> >> request is answered wrong. I *think* the vendor driver sends the
> >> USB_MODE_AUTORUN request only once but it is hard to tell…
> > 
> > Does the below patch solve the issue ?
> 
> So you kill the please-load-the-firware bit and avoid further questions
> regarding its state. Yes, it helps as in my test-case is now running
> for ~15h. I see the "NIC in AutoRun mode" just once. Thanks.
> 
> I am still curious why it answers wrong but lets hope the first answer
> is correct :)

I don't know, perhaps this value is only valid at initialization stage.
Looks that vendor driver reads it only once and saves it as flag in the
memory.

Stanislaw