From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Kalle Valo <kvalo@codeaurora.org>,
linux-wireless@vger.kernel.org,
Helmut Schaa <helmut.schaa@googlemail.com>
Subject: [PATCH] rt2800usb: check Autorun mode on FW load only once
Date: Thu, 19 Mar 2015 15:32:49 +0100 [thread overview]
Message-ID: <20150319143249.GB2516@redhat.com> (raw)
In-Reply-To: <550ACDF2.30507@linutronix.de>
Seems H/W report correctly firmware Autorun value only at initialization
stage. When we close interface and open it again, Autorun value is 0 and
we try to load firmware what kills the device. To fix clear
REQUIRE_FIRMWARE firmware flag, to do not load firmware again, once we
discover Autorun mode.
Reported-and-tested-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
---
drivers/net/wireless/rt2x00/rt2800usb.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/wireless/rt2x00/rt2800usb.c b/drivers/net/wireless/rt2x00/rt2800usb.c
index 9a2f44a..3a6cae8 100644
--- a/drivers/net/wireless/rt2x00/rt2800usb.c
+++ b/drivers/net/wireless/rt2x00/rt2800usb.c
@@ -293,6 +293,7 @@ static int rt2800usb_write_firmware(struct rt2x00_dev *rt2x00dev,
if (retval) {
rt2x00_info(rt2x00dev,
"Firmware loading not required - NIC in AutoRun mode\n");
+ __clear_bit(REQUIRE_FIRMWARE, &rt2x00dev->cap_flags);
} else {
rt2x00usb_register_multiwrite(rt2x00dev, FIRMWARE_IMAGE_BASE,
data + offset, length);
--
1.8.3.1
next prev parent reply other threads:[~2015-03-19 14:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-12 14:35 [PATCH 1/3] rt2x00usb: initialize the read value in case of failure Sebastian Andrzej Siewior
2015-03-12 14:35 ` [PATCH 2/3] rt2x00usb: check USB's request error code in rt2800usb_autorun_detect() Sebastian Andrzej Siewior
2015-03-12 14:35 ` [PATCH 3/3] rt2x00usb: drop rt2x00usb_disable_radio() from rt2800usb_disable_radio() Sebastian Andrzej Siewior
2015-03-16 16:06 ` [1/3] rt2x00usb: initialize the read value in case of failure Kalle Valo
2015-03-16 16:41 ` Sebastian Andrzej Siewior
2015-03-17 8:34 ` Sebastian Andrzej Siewior
2015-03-18 13:11 ` Stanislaw Gruszka
2015-03-19 13:24 ` Sebastian Andrzej Siewior
2015-03-19 14:30 ` Stanislaw Gruszka
2015-03-19 14:32 ` Stanislaw Gruszka [this message]
2015-03-30 8:29 ` rt2800usb: check Autorun mode on FW load only once Kalle Valo
2015-03-18 12:48 ` [1/3] rt2x00usb: initialize the read value in case of failure Stanislaw Gruszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150319143249.GB2516@redhat.com \
--to=sgruszka@redhat.com \
--cc=bigeasy@linutronix.de \
--cc=helmut.schaa@googlemail.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).