* [PATCH] mwifiex: fix crash in SDIO RX path
@ 2015-03-18 14:42 Avinash Patil
2015-03-20 7:07 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Avinash Patil @ 2015-03-18 14:42 UTC (permalink / raw)
To: linux-wireless; +Cc: akarwar, cluo, liuzy, Avinash Patil
With patch '960d6d08e39 "mwifiex: delay skb allocation for RX
until cmd53 over"' we no more pass skb parameter to MP aggregation setup
helper function. We instead pass length to be aggregated.
This patch fixes an issue where we were passing length parameter of NULL
skb to aggregation routine resulting into crash. We should instead pass
rx_len received from mp_regs.
Signed-off-by: Avinash Patil <patila@marvell.com>
Signed-off-by: Amitkumar Karwar <akarwar@marvell.com>
---
drivers/net/wireless/mwifiex/sdio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/mwifiex/sdio.c b/drivers/net/wireless/mwifiex/sdio.c
index 330e9d0..4f08c58 100644
--- a/drivers/net/wireless/mwifiex/sdio.c
+++ b/drivers/net/wireless/mwifiex/sdio.c
@@ -1375,7 +1375,7 @@ rx_curr_single:
if (f_post_aggr_cur) {
dev_dbg(adapter->dev, "info: current packet aggregation\n");
/* Curr pkt can be aggregated */
- mp_rx_aggr_setup(card, skb->len, port);
+ mp_rx_aggr_setup(card, rx_len, port);
}
return 0;
--
1.8.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: mwifiex: fix crash in SDIO RX path
2015-03-18 14:42 [PATCH] mwifiex: fix crash in SDIO RX path Avinash Patil
@ 2015-03-20 7:07 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2015-03-20 7:07 UTC (permalink / raw)
To: Avinash Patil; +Cc: linux-wireless, akarwar, cluo, liuzy, Avinash Patil
> With patch '960d6d08e39 "mwifiex: delay skb allocation for RX
> until cmd53 over"' we no more pass skb parameter to MP aggregation setup
> helper function. We instead pass length to be aggregated.
>
> This patch fixes an issue where we were passing length parameter of NULL
> skb to aggregation routine resulting into crash. We should instead pass
> rx_len received from mp_regs.
>
> Signed-off-by: Avinash Patil <patila@marvell.com>
> Signed-off-by: Amitkumar Karwar <akarwar@marvell.com>
Thanks, applied to wireless-drivers-next.git.
Kalle Valo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-03-20 7:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-18 14:42 [PATCH] mwifiex: fix crash in SDIO RX path Avinash Patil
2015-03-20 7:07 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).