Re: [PATCH] staging: rtl8192u: ieee80211: Silence sparse warning

[Dan Carpenter <dan.carpenter@oracle.com>]

On Wed, May 13, 2015 at 10:04:14PM -0300, Gaston Gonzalez wrote:
> @@ -327,7 +280,7 @@ static int ieee80211_tkip_encrypt(struct sk_buff
> *skb, int hdr_len, void *priv)
>                      tkey->tx_iv32);
>              tkey->tx_phase1_done = 1;
>          }
> -        tkip_mixing_phase2(rc4key, tkey->key, tkey->tx_ttak,
> tkey->tx_iv16);
> +        tkip_mixing_phase2(tkey->key, tkey->tx_ttak, tkey->tx_iv16,
> rc4key);
>      }
>      else
>      tkey->tx_phase1_done = 1;
> @@ -447,4 +400,4 @@ static int ieee80211_tkip_decrypt(struct sk_buff
> *skb, int hdr_len, void *priv)
>              tkip_mixing_phase1(tkey->rx_ttak, tkey->key, hdr->addr2, iv32);
>              tkey->rx_phase1_done = 1;
>          }
> -        tkip_mixing_phase2(rc4key, tkey->key, tkey->rx_ttak, iv16);
> +        tkip_mixing_phase2(tkey->key, tkey->rx_ttak, iv16, rc4key);
> 
>         plen = skb->len - hdr_len - 12;
> 

This patch got corrupted over email, so I can't review it inline, but it
looks much more reasonable.

regards,
dan carpenter