From: "Luis R. Rodriguez" <mcgrof@suse.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "Luis R. Rodriguez" <mcgrof@do-not-panic.com>,
ming.lei@canonical.com, rusty@rustcorp.com.au,
torvalds@linux-foundation.org, dhowells@redhat.com,
seth.forshee@canonical.com, linux-kernel@vger.kernel.org,
pebolle@tiscali.nl, linux-wireless@vger.kernel.org,
gregkh@linuxfoundation.org, jlee@suse.com, tiwai@suse.de,
casey@schaufler-ca.com, keescook@chromium.org,
mjg59@srcf.ucam.org, akpm@linux-foundation.org,
Kyle McMartin <kyle@kernel.org>,
Bruce Allan <bruce.w.allan@intel.com>,
Tadeusz Struk <tadeusz.struk@intel.com>,
John Griffin <john.griffin@intel.com>
Subject: Re: [RFC v2 3/6] crypto: qat - address recursive dependency when fw signing is enabled
Date: Thu, 14 May 2015 21:34:45 +0200 [thread overview]
Message-ID: <20150514193445.GW23057@wotan.suse.de> (raw)
In-Reply-To: <20150514030415.GD3853@gondor.apana.org.au>
On Thu, May 14, 2015 at 11:04:15AM +0800, Herbert Xu wrote:
> On Wed, May 13, 2015 at 11:23:53AM -0700, Luis R. Rodriguez wrote:
> > From: "Luis R. Rodriguez" <mcgrof@suse.com>
> >
> > We're going to add firmware module signing support, but when we do
> > this we end up with the following recursive dependency. Fix this by
> > just depending on FW_LOADER, which is typically always enabled
> > anyway. We do this as a compromise for now as FW_LOADER is only
> > selectable when EXPERT is enabled and the recursive dependency issue
> > below is actually real and valid, its proper fix however requires
> > a bit of work.
> >
> > This technically means this change is likely welcomed for other
> > parts of the kernel but this is really only needed for now here.
>
> Nack. Either fix kbuild or make every user of FW_LOADER use
> a dependency. Singling out a single crypto device makes zero
> sense.
I think that's fair... Paul, did you get to look into the
recursive issue some more by any chance? Any preference for
what path to take here?
Luis
next prev parent reply other threads:[~2015-05-14 19:34 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-13 18:23 [RFC v2 0/6] firmware: add PKCS#7 firmware signature support Luis R. Rodriguez
2015-05-13 18:23 ` [RFC v2 1/6] firmware: generalize reading file contents as a helper Luis R. Rodriguez
2015-05-13 18:23 ` [RFC v2 2/6] kernel: generalize module signing as system data signing Luis R. Rodriguez
2015-05-13 18:23 ` [RFC v2 3/6] crypto: qat - address recursive dependency when fw signing is enabled Luis R. Rodriguez
2015-05-14 3:04 ` Herbert Xu
2015-05-14 19:34 ` Luis R. Rodriguez [this message]
2015-05-13 18:23 ` [RFC v2 4/6] scripts/sign-file.c: add support to only create signature file Luis R. Rodriguez
2015-05-14 14:50 ` David Howells
2015-05-14 14:52 ` David Howells
2015-05-14 14:52 ` Luis R. Rodriguez
2015-05-14 15:02 ` David Howells
2015-05-14 15:16 ` Luis R. Rodriguez
2015-05-13 18:23 ` [RFC v2 5/6] kernel/sysdata_signing: export data_verify_pkcs7() Luis R. Rodriguez
2015-05-13 18:23 ` [RFC v2 6/6] firmware: add firmware signature checking support Luis R. Rodriguez
2015-05-13 18:46 ` Luis R. Rodriguez
2015-05-14 0:31 ` Julian Calaby
2015-05-14 1:35 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150514193445.GW23057@wotan.suse.de \
--to=mcgrof@suse.com \
--cc=akpm@linux-foundation.org \
--cc=bruce.w.allan@intel.com \
--cc=casey@schaufler-ca.com \
--cc=dhowells@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=herbert@gondor.apana.org.au \
--cc=jlee@suse.com \
--cc=john.griffin@intel.com \
--cc=keescook@chromium.org \
--cc=kyle@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mcgrof@do-not-panic.com \
--cc=ming.lei@canonical.com \
--cc=mjg59@srcf.ucam.org \
--cc=pebolle@tiscali.nl \
--cc=rusty@rustcorp.com.au \
--cc=seth.forshee@canonical.com \
--cc=tadeusz.struk@intel.com \
--cc=tiwai@suse.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox