From: Dan Carpenter <dan.carpenter@oracle.com>
To: Larry.Finger@lwfinger.net
Cc: Larry Finger <Larry.Finger@lwfinger.net>, linux-wireless@vger.kernel.org
Subject: re: rtlwifi: rtl8821ae: Move driver from staging to regular tree
Date: Mon, 18 May 2015 15:31:38 +0300 [thread overview]
Message-ID: <20150518123138.GC32633@mwanda> (raw)
Hello Larry Finger,
The patch 21e4b0726dc6: "rtlwifi: rtl8821ae: Move driver from staging
to regular tree" from Sep 22, 2014, leads to the following static
checker warning:
drivers/net/wireless/rtlwifi/rtl8821ae/hw.c:2183 _rtl8821ae_set_media_status()
warn: masked condition is always false. '(bt_msr & 252) == 3'
drivers/net/wireless/rtlwifi/rtl8821ae/hw.c
2181 rtl_write_byte(rtlpriv, MSR, bt_msr);
2182 rtlpriv->cfg->ops->led_control(hw, ledaction);
2183 if ((bt_msr & 0xfc) == MSR_AP)
^^^^^^^^^^^^^^^^^^^^^^^^^
This condition is never true. We mask out the 0xfc flags at the
beginning of the function. MSR_AP is 0x3.
2184 rtl_write_byte(rtlpriv, REG_BCNTCFG + 1, 0x00);
2185 else
2186 rtl_write_byte(rtlpriv, REG_BCNTCFG + 1, 0x66);
2187
2188 return 0;
2189 }
regards,
dan carpenter
reply other threads:[~2015-05-18 12:31 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150518123138.GC32633@mwanda \
--to=dan.carpenter@oracle.com \
--cc=Larry.Finger@lwfinger.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).