* re: rtlwifi: rtl8821ae: Move driver from staging to regular tree
@ 2015-05-18 12:31 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2015-05-18 12:31 UTC (permalink / raw)
To: Larry.Finger; +Cc: Larry Finger, linux-wireless
Hello Larry Finger,
The patch 21e4b0726dc6: "rtlwifi: rtl8821ae: Move driver from staging
to regular tree" from Sep 22, 2014, leads to the following static
checker warning:
drivers/net/wireless/rtlwifi/rtl8821ae/hw.c:2183 _rtl8821ae_set_media_status()
warn: masked condition is always false. '(bt_msr & 252) == 3'
drivers/net/wireless/rtlwifi/rtl8821ae/hw.c
2181 rtl_write_byte(rtlpriv, MSR, bt_msr);
2182 rtlpriv->cfg->ops->led_control(hw, ledaction);
2183 if ((bt_msr & 0xfc) == MSR_AP)
^^^^^^^^^^^^^^^^^^^^^^^^^
This condition is never true. We mask out the 0xfc flags at the
beginning of the function. MSR_AP is 0x3.
2184 rtl_write_byte(rtlpriv, REG_BCNTCFG + 1, 0x00);
2185 else
2186 rtl_write_byte(rtlpriv, REG_BCNTCFG + 1, 0x66);
2187
2188 return 0;
2189 }
regards,
dan carpenter
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2015-05-18 12:31 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-18 12:31 rtlwifi: rtl8821ae: Move driver from staging to regular tree Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).