From: Henrik Eriksson <henrik.eriksson@axis.com>
To: brcm80211-dev-list@broadcom.com, linux-wireless@vger.kernel.org
Subject: [PATCH] brcmfmac: clear sdiodev->pdata if irq_of_parse_and_map fails
Date: Wed, 20 May 2015 16:02:15 +0200 [thread overview]
Message-ID: <20150520140206.GA11272@linux.se.axis.com> (raw)
Clear the pdata pointer in sdiodev after freeing the memory. In my case
not doing so interferes with device initialization as request_irq of
sdiodev->pdata->oob_irq_nr fails, but even if not, leaving a wild
pointer is incorrect.
Signed-off-by: Henrik Eriksson <henriken@axis.com>
---
drivers/net/wireless/brcm80211/brcmfmac/of.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/wireless/brcm80211/brcmfmac/of.c b/drivers/net/wireless/brcm80211/brcmfmac/of.c
index c824570..71ead7b 100644
--- a/drivers/net/wireless/brcm80211/brcmfmac/of.c
+++ b/drivers/net/wireless/brcm80211/brcmfmac/of.c
@@ -43,6 +43,7 @@ void brcmf_of_probe(struct brcmf_sdio_dev *sdiodev)
if (!irq) {
brcmf_err("interrupt could not be mapped\n");
devm_kfree(dev, sdiodev->pdata);
+ sdiodev->pdata = NULL;
return;
}
irqf = irqd_get_trigger_type(irq_get_irq_data(irq));
--
2.0.4
next reply other threads:[~2015-05-20 14:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-20 14:02 Henrik Eriksson [this message]
2015-05-20 14:57 ` [PATCH] brcmfmac: clear sdiodev->pdata if irq_of_parse_and_map fails Henrik Eriksson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150520140206.GA11272@linux.se.axis.com \
--to=henrik.eriksson@axis.com \
--cc=brcm80211-dev-list@broadcom.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).