From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:53684 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753768AbbE1I3a (ORCPT ); Thu, 28 May 2015 04:29:30 -0400 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Subject: Re: brcmfmac: fix invalid access to struct acpi_device fields From: Kalle Valo In-Reply-To: <1432747901-8472-1-git-send-email-arend@broadcom.com> To: Arend van Spriel Cc: linux-wireless , Arend van Spriel , "Fu, Zhonghui" Message-Id: <20150528082929.34ED7140394@smtp.codeaurora.org> (sfid-20150528_102949_871635_400A9819) Date: Thu, 28 May 2015 08:29:29 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org List-ID: > The fields of struct acpi_device are only known when CONFIG_ACPI is > defined. Fix this by using a helper function. This will resolve the > issue found in linux-next: > > ../brcmfmac/bcmsdh.c: In function 'brcmf_ops_sdio_probe': > ../brcmfmac/bcmsdh.c:1139:7: error: dereferencing pointer to incomplete type > adev->flags.power_manageable = 0; > ^ > > Fixes: f0992ace680c ("brcmfmac: prohibit ACPI power management ...") > Cc: Fu, Zhonghui > Reported-by: Stephen Rothwell > Signed-off-by: Arend van Spriel Thanks, applied to wireless-drivers-next.git. Kalle Valo