From: Stanislav Kholmanskikh <kholmanskikh.s.s@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: johnny.kim@atmel.com, rachel.kim@atmel.com, dean.lee@atmel.com,
chris.park@atmel.com, devel@driverdev.osuosl.org,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] staging: wilc1000: Fix some compile warnings
Date: Mon, 1 Jun 2015 22:02:31 +0300 [thread overview]
Message-ID: <20150601190231.GA2631@kholmanskikh> (raw)
In-Reply-To: <20150530235941.GB20036@kroah.com>
Hello.
On Sun, May 31, 2015 at 08:59:41AM +0900, Greg KH wrote:
> On Sat, May 30, 2015 at 11:44:18PM +0300, Stanislav Kholmanskikh wrote:
> > This patch reduces (a little bit) the amount of compile time
> > warnings.
> >
> > The change of WILC_WFI_init_mon_interface() prototype seems to be ok,
> > because alloc_netdev() also expects 'const char *name'.
>
> You are doing different types of fixes here, please be explicit about
> what you are doing and break this up into logical patches that each only
> do one type of thing.
Thank you for review.
I've just sent an updated version which addresses your comments.
Thanks.
>
> thanks,
>
> greg k-h
prev parent reply other threads:[~2015-06-01 19:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-30 20:44 [PATCH 1/2] staging: wilc1000: Fix some compile warnings Stanislav Kholmanskikh
2015-05-30 20:44 ` [PATCH 2/2] staging: wilc1000: Cleanup to coreconfigurator Stanislav Kholmanskikh
2015-05-31 0:00 ` Greg KH
2015-05-30 23:59 ` [PATCH 1/2] staging: wilc1000: Fix some compile warnings Greg KH
2015-06-01 19:02 ` Stanislav Kholmanskikh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150601190231.GA2631@kholmanskikh \
--to=kholmanskikh.s.s@gmail.com \
--cc=chris.park@atmel.com \
--cc=dean.lee@atmel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=johnny.kim@atmel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=rachel.kim@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).