From: Jouni Malinen <j@w1.fi>
To: Stephan Mueller <smueller@chronox.de>
Cc: Johannes Berg <johannes@sipsolutions.net>,
Herbert Xu <herbert@gondor.apana.org.au>,
Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Marcel Holtmann <marcel@holtmann.org>,
Steffen Klassert <steffen.klassert@secunet.com>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 7/7] mac80211: Switch to new AEAD interface
Date: Tue, 2 Jun 2015 12:15:43 +0300 [thread overview]
Message-ID: <20150602091543.GA3140@w1.fi> (raw)
In-Reply-To: <2613062.1qx4rgqk9F@tauon>
On Mon, Jun 01, 2015 at 05:36:58PM +0200, Stephan Mueller wrote:
> Am Montag, 1. Juni 2015, 16:35:26 schrieb Johannes Berg:
> >IOW, I think something like this would make sense:
>
> That looks definitely cleaner :-)
Indeed.. That AAD length-in-the-buffer design came from the over ten
year old code that was optimized to cover the CCM construction with the
same buffer and that was not cleaned up when this was converted to use
cryptoapi couple of years ago.
> Though, my main concern was just to ensure that the aad length value is not
> zero.
It won't be in IEEE 802.11 use cases. The exact length depends on the
IEEE 802.11 frame type, but AAD is constructed in a way that it is
normally a bit over 20 octets while allowing CCM to fit the related
operations into two AES blocks.
--
Jouni Malinen PGP id EFC895FA
prev parent reply other threads:[~2015-06-02 9:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20150521103938.GA23035@gondor.apana.org.au>
[not found] ` <1706098.2opyZ2hT8S@tachyon.chronox.de>
[not found] ` <1433166161.3505.7.camel@sipsolutions.net>
[not found] ` <2141601.IbD2v8KjaT@tauon>
[not found] ` <1433167519.3505.11.camel@sipsolutions.net>
2015-06-01 14:35 ` [PATCH 7/7] mac80211: Switch to new AEAD interface Johannes Berg
2015-06-01 15:36 ` Stephan Mueller
2015-06-02 9:15 ` Jouni Malinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150602091543.GA3140@w1.fi \
--to=j@w1.fi \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=johannes@sipsolutions.net \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=netdev@vger.kernel.org \
--cc=smueller@chronox.de \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).