From: "Jakub Kiciński" <moorray3@wp.pl>
To: Yanbo Li <yanbol@qca.qualcomm.com>
Cc: <kvalo@qca.qualcomm.com>, <dreamfly281@gmail.com>,
<ath10k@lists.infradead.org>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v2] ath10k: Debugfs entry to enable/disable WLAN&Blutooth Coexist feature
Date: Tue, 2 Jun 2015 11:39:01 +0200 [thread overview]
Message-ID: <20150602113901.2da3542d@north> (raw)
In-Reply-To: <1432840745-21725-1-git-send-email-yanbol@qca.qualcomm.com>
On Thu, 28 May 2015 12:19:05 -0700, Yanbo Li wrote:
> As some radio have no connection with BT modules, enable the WLAN/Bluetooth
> coexist(BTC) feature will has some side effect if the radio's GPIO connect
> with any other HW modules. Add the control switcher "btc_feature" at
> debugfs and set the feature as disable by default to avoid such case.
>
> To enable this feature, execute:
> echo 1 > /sys/kernel/debug/ieee80211/phyX/ath10k/btc_feature
> To disable:
> echo 0 > /sys/kernel/debug/ieee80211/phyX/ath10k/btc_feature
>
> Signed-off-by: Yanbo Li <yanbol@qca.qualcomm.com>
IMHO common API for disabling/enabling btcoex is something we would all
benefit from and easy enough to implement properly. Burying it in
driver-specific debugfs is less than appropriate.
I seem to recall there were plans to discuss btcoex at one of the
linux-wireless summits. If the consensus was to leave it in debugfs
then I apologize for the noise ;)
next prev parent reply other threads:[~2015-06-02 9:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-28 19:19 [PATCH v2] ath10k: Debugfs entry to enable/disable WLAN&Blutooth Coexist feature Yanbo Li
2015-06-02 9:39 ` Jakub Kiciński [this message]
2015-06-02 12:10 ` Kalle Valo
2015-06-03 0:18 ` Li, Yanbo
[not found] ` <CAFqt6zbpEfX_DPwZwzVZkcUD3uuYa=-Ujuo9PXcB+-HtM9b8tA@mail.gmail.com>
2015-06-03 9:56 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150602113901.2da3542d@north \
--to=moorray3@wp.pl \
--cc=ath10k@lists.infradead.org \
--cc=dreamfly281@gmail.com \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=yanbol@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).