From: Greg KH <gregkh@linuxfoundation.org>
To: Stanislav Kholmanskikh <kholmanskikh.s.s@gmail.com>
Cc: johnny.kim@atmel.com, rachel.kim@atmel.com, dean.lee@atmel.com,
chris.park@atmel.com, devel@driverdev.osuosl.org,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/2] staging: wilc1000: Cleanup to coreconfigurator
Date: Tue, 9 Jun 2015 10:39:29 -0700 [thread overview]
Message-ID: <20150609173929.GA22547@kroah.com> (raw)
In-Reply-To: <1433796869-2737-1-git-send-email-kholmanskikh.s.s@gmail.com>
On Mon, Jun 08, 2015 at 11:54:28PM +0300, Stanislav Kholmanskikh wrote:
> Fixed the following issues found with checkpatch.pl:
>
> * Multiple debug strings contained " \n". Changed
> it to "\n".
>
> * Changed 'return(X)' to 'return X'.
>
> * Aligned TAG_PARAM_OFFSET to fit 80 columns
That is 3 different things, please make this 3 different patches.
Remember, each patch can only do one thing.
thanks,
greg k-h
prev parent reply other threads:[~2015-06-09 17:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-08 20:54 [PATCH v4 1/2] staging: wilc1000: Cleanup to coreconfigurator Stanislav Kholmanskikh
2015-06-08 20:54 ` [PATCH v4 2/2] staging: wilc1000: Align enum members in coreconfigurator Stanislav Kholmanskikh
2015-06-09 17:39 ` Greg KH
2015-06-10 18:59 ` Stanislav Kholmanskikh
2015-06-09 17:39 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150609173929.GA22547@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=chris.park@atmel.com \
--cc=dean.lee@atmel.com \
--cc=devel@driverdev.osuosl.org \
--cc=johnny.kim@atmel.com \
--cc=kholmanskikh.s.s@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=rachel.kim@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).