From: Dan Carpenter <dan.carpenter@oracle.com>
To: Johnny Kim <johnny.kim@atmel.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-wireless@vger.kernel.org, Rachel.kim@atmel.com,
dean.lee@atmel.com, tony.cho@atmel.com, chris.park@atmel.com
Subject: Re: [PATCH 1/4] staging: wilc1000: modify data type
Date: Wed, 10 Jun 2015 12:36:11 +0300 [thread overview]
Message-ID: <20150610093611.GD28762@mwanda> (raw)
In-Reply-To: <1433923607-20927-2-git-send-email-johnny.kim@atmel.com>
On Wed, Jun 10, 2015 at 05:06:44PM +0900, Johnny Kim wrote:
> This replace the argument of the function to the independent data type
> in system.
>
> Signed-off-by: Johnny Kim <johnny.kim@atmel.com>
This changelog says what you are doing but not why.
What is the point of ->u32Address? Now that it's not 32 bits, the name
makes no sense. Why not just make it a pointer?
There was someone changing all the datatypes with sed. In some ways,
those patches were easier to review because they were mindless and not
really expected to make sense. After we just sed the code to make it
look more normal then we can think about 64 bit bugs (like this patch
and the next).
regards,
dan carpenter
next prev parent reply other threads:[~2015-06-10 9:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-10 8:06 [PATCH 0/4] staging: wilc1000: fix compile warnings and clean other Johnny Kim
2015-06-10 8:06 ` [PATCH 1/4] staging: wilc1000: modify data type Johnny Kim
2015-06-10 9:36 ` Dan Carpenter [this message]
2015-06-11 0:40 ` Greg KH
2015-06-11 5:33 ` Johnny Kim
2015-06-11 14:46 ` Greg KH
2015-06-10 8:06 ` [PATCH 2/4] staging: wilc1000: add syntax for 64-bit machine Johnny Kim
2015-06-10 10:12 ` Julian Calaby
2015-06-10 19:37 ` Greg KH
2015-06-10 8:06 ` [PATCH 3/4] staging: wilc1000: modify printk format Johnny Kim
2015-06-11 0:42 ` Greg KH
2015-06-10 8:06 ` [PATCH 4/4] staging: wilc1000: remove uninitialized warnings Johnny Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150610093611.GD28762@mwanda \
--to=dan.carpenter@oracle.com \
--cc=Rachel.kim@atmel.com \
--cc=chris.park@atmel.com \
--cc=dean.lee@atmel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=johnny.kim@atmel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=tony.cho@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).