* [PATCH] staging: wilc1000: update TODO list
@ 2015-06-12 10:23 Dean Lee
2015-06-12 11:07 ` Sudip Mukherjee
2015-06-12 15:27 ` Greg KH
0 siblings, 2 replies; 3+ messages in thread
From: Dean Lee @ 2015-06-12 10:23 UTC (permalink / raw)
To: gregkh, devel, linux-wireless
Cc: johnny.kim, chris.park, rachel.kim, dean.lee
remove complete OS wrapper functions.
Signed-off-by: Dean Lee <dean.lee@atmel.com>
---
drivers/staging/wilc1000/TODO | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/wilc1000/TODO b/drivers/staging/wilc1000/TODO
index 95199d8..e876008 100644
--- a/drivers/staging/wilc1000/TODO
+++ b/drivers/staging/wilc1000/TODO
@@ -1,6 +1,5 @@
TODO:
- remove the defined feature as kernel versions
-- remove OS wrapper functions
- remove custom debug and tracing functions
- rework comments and function headers(also coding style)
- replace all semaphores with mutexes or completions
--
2.4.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: wilc1000: update TODO list
2015-06-12 10:23 [PATCH] staging: wilc1000: update TODO list Dean Lee
@ 2015-06-12 11:07 ` Sudip Mukherjee
2015-06-12 15:27 ` Greg KH
1 sibling, 0 replies; 3+ messages in thread
From: Sudip Mukherjee @ 2015-06-12 11:07 UTC (permalink / raw)
To: Dean Lee
Cc: gregkh, devel, linux-wireless, rachel.kim, chris.park, johnny.kim
On Fri, Jun 12, 2015 at 07:23:11PM +0900, Dean Lee wrote:
> remove complete OS wrapper functions.
just a minor thing. It will be easy if you send your patches in series
instead of separate patches. your patch "remove oswrapper & type file"
is dependent on one of the previous patch that you have sent today. If
for some reason that previous patch is not applied then
"remove oswrapper & type file" will not apply and then this patch will
have no meaning.
regards
sudip
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: wilc1000: update TODO list
2015-06-12 10:23 [PATCH] staging: wilc1000: update TODO list Dean Lee
2015-06-12 11:07 ` Sudip Mukherjee
@ 2015-06-12 15:27 ` Greg KH
1 sibling, 0 replies; 3+ messages in thread
From: Greg KH @ 2015-06-12 15:27 UTC (permalink / raw)
To: Dean Lee; +Cc: devel, linux-wireless, johnny.kim, chris.park, rachel.kim
On Fri, Jun 12, 2015 at 07:23:11PM +0900, Dean Lee wrote:
> remove complete OS wrapper functions.
>
> Signed-off-by: Dean Lee <dean.lee@atmel.com>
> ---
> drivers/staging/wilc1000/TODO | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/wilc1000/TODO b/drivers/staging/wilc1000/TODO
> index 95199d8..e876008 100644
> --- a/drivers/staging/wilc1000/TODO
> +++ b/drivers/staging/wilc1000/TODO
> @@ -1,6 +1,5 @@
> TODO:
> - remove the defined feature as kernel versions
> -- remove OS wrapper functions
> - remove custom debug and tracing functions
> - rework comments and function headers(also coding style)
> - replace all semaphores with mutexes or completions
> --
> 2.4.3
This isn't done yet, please make it the last patch in your series.
And are you sure you have removed them all?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-06-12 15:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-12 10:23 [PATCH] staging: wilc1000: update TODO list Dean Lee
2015-06-12 11:07 ` Sudip Mukherjee
2015-06-12 15:27 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).