From: Greg KH <gregkh@linuxfoundation.org>
To: Dean Lee <dean.lee@atmel.com>
Cc: devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org,
rachel.kim@atmel.com, chris.park@atmel.com, johnny.kim@atmel.com
Subject: Re: [PATCH 2/2] staging: wilc1000: modify uninitialized warning
Date: Tue, 16 Jun 2015 19:21:35 -0700 [thread overview]
Message-ID: <20150617022135.GA18464@kroah.com> (raw)
In-Reply-To: <1434438685-24336-2-git-send-email-dean.lee@atmel.com>
On Tue, Jun 16, 2015 at 04:11:25PM +0900, Dean Lee wrote:
> initialize it.
>
> Signed-off-by: Dean Lee <dean.lee@atmel.com>
> ---
> drivers/staging/wilc1000/host_interface.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
> index 358283f..03e6bc5 100644
> --- a/drivers/staging/wilc1000/host_interface.c
> +++ b/drivers/staging/wilc1000/host_interface.c
> @@ -7241,7 +7241,7 @@ s32 host_int_add_beacon(WILC_WFIDrvHandle hWFIDrv, u32 u32Interval,
> s32 s32Error = WILC_SUCCESS;
> tstrWILC_WFIDrv *pstrWFIDrv = (tstrWILC_WFIDrv *)hWFIDrv;
> tstrHostIFmsg strHostIFmsg;
> - tstrHostIFSetBeacon *pstrSetBeaconParam = &strHostIFmsg.uniHostIFmsgBody.strHostIFSetBeacon;
> + tstrHostIFSetBeacon *pstrSetBeaconParam = NULL;
This isn't fixing an "unitialized pointer" warning, the code is just
fine.
Well, it's really odd, but it is correct, there's nothing really wrong
here that I can see.
thanks,
greg k-h
next prev parent reply other threads:[~2015-06-17 2:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-16 7:11 [PATCH 1/2] staging: wilc1000: modify type casting warning Dean Lee
2015-06-16 7:11 ` [PATCH 2/2] staging: wilc1000: modify uninitialized warning Dean Lee
2015-06-17 2:21 ` Greg KH [this message]
2015-06-16 13:06 ` [PATCH 1/2] staging: wilc1000: modify type casting warning Greg KH
2015-06-22 9:29 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150617022135.GA18464@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=chris.park@atmel.com \
--cc=dean.lee@atmel.com \
--cc=devel@driverdev.osuosl.org \
--cc=johnny.kim@atmel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=rachel.kim@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).