From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Johnny Kim <johnny.kim@atmel.com>,
Rachel Kim <rachel.kim@atmel.com>, Dean Lee <dean.lee@atmel.com>,
Chris Park <chris.park@atmel.com>,
devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: wilc1000: remove WILC_WFIDrvHandle
Date: Wed, 17 Jun 2015 07:03:13 -0700 [thread overview]
Message-ID: <20150617140313.GA17337@kroah.com> (raw)
In-Reply-To: <1434546980-19094-1-git-send-email-sudipm.mukherjee@gmail.com>
On Wed, Jun 17, 2015 at 06:46:20PM +0530, Sudip Mukherjee wrote:
> WILC_WFIDrvHandle was:
>
> typedef struct {
> s32 s32Dummy;
> } *WILC_WFIDrvHandle;
>
> which basically meant a pointer to an integer.
> so removed the typedef and replaced all WILC_WFIDrvHandle with int *
>
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> ---
>
> replacement was done by using sed, just manually removed the typedef.
> build ok, before this change total 77 build warning, after this patch
> same number of warnings.
Which means this is not the correct fix for this :)
The driver is obviously broken for 64bit systems, and these warnings are
showing that, let's fix this "correctly" please.
sorry, I'm not going to take this patch.
greg k-h
prev parent reply other threads:[~2015-06-17 14:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-17 13:16 [PATCH] staging: wilc1000: remove WILC_WFIDrvHandle Sudip Mukherjee
2015-06-17 14:03 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150617140313.GA17337@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=chris.park@atmel.com \
--cc=dean.lee@atmel.com \
--cc=devel@driverdev.osuosl.org \
--cc=johnny.kim@atmel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=rachel.kim@atmel.com \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).