From: Greg KH <gregkh@linuxfoundation.org>
To: 조성훈 <ywhsbliss@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org,
johnny.kim@atmel.com, chris.park@atmel.com, Rachel.kim@atmel.com,
dean.lee@atmel.com
Subject: Re: [PATCH 4/5] staging: wilc1000: remove prohibited spaces.
Date: Thu, 18 Jun 2015 07:42:38 -0700 [thread overview]
Message-ID: <20150618144238.GB8830@kroah.com> (raw)
In-Reply-To: <CAAYiv+Yx-KzqE9UKeEO2NHJbzy8XL2z3YH5BbkXiBgXLHRhK7Q@mail.gmail.com>
On Thu, Jun 18, 2015 at 01:51:15PM +0900, 조성훈 wrote:
> Hi Greg,
> I want to make sure one thing before going further. I cloned the
> staging-testing and then made the first patch. There was no problem when I sent
> the first path to you.
> Afterwards, I also pulled the repository to update my local tree before making
> the second patch. So, I thought I made this second patch based on top of the
> latest commits.
>
> I am confused why you said I need rebase. Do you mean I have to make my branch
> (for example, staging-wilc1000) from staging-testing and then rebase my commits
> to staging-testing branch before making patch files with git format-patch?
You made the patches correctly, I just accepted patches that were sent
before yours to the tree, which then conflicted with your patches.
That's what happens with a fast-moving tree and a driver that lots of
people are all trying to clean up at the same time.
So rebase on staging-testing again and resend and you should be fine.
thanks,
greg k-h
next prev parent reply other threads:[~2015-06-18 14:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-17 5:42 [PATCH 1/5] staging: wilc1000: remove the warnings on the multiple blank lines Sunghoon Cho
2015-06-17 5:42 ` [PATCH 2/5] staging: wilc1000: remove unnecessary blank line Sunghoon Cho
2015-06-17 5:42 ` [PATCH 3/5] staging: wilc1000: remove the warnings on line over 80 characters Sunghoon Cho
2015-06-18 4:16 ` Greg KH
2015-06-17 5:42 ` [PATCH 4/5] staging: wilc1000: remove prohibited spaces Sunghoon Cho
2015-06-18 4:18 ` Greg KH
[not found] ` <CAAYiv+Yx-KzqE9UKeEO2NHJbzy8XL2z3YH5BbkXiBgXLHRhK7Q@mail.gmail.com>
2015-06-18 14:42 ` Greg KH [this message]
2015-06-17 5:42 ` [PATCH 5/5] staging: wilc1000: add a blank line Sunghoon Cho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150618144238.GB8830@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Rachel.kim@atmel.com \
--cc=chris.park@atmel.com \
--cc=dean.lee@atmel.com \
--cc=devel@driverdev.osuosl.org \
--cc=johnny.kim@atmel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=ywhsbliss@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).