From: Dan Carpenter <dan.carpenter@oracle.com>
To: mgreer@animalcreek.com
Cc: linux-wireless@vger.kernel.org
Subject: re: NFC: trf7970a: Handle extra byte in response to Type 5 RMB commands
Date: Tue, 23 Jun 2015 16:07:04 +0300 [thread overview]
Message-ID: <20150623130703.GA27051@mwanda> (raw)
Hello Mark A. Greer,
This is a semi-automatic email about new static checker warnings.
The patch ab714817d7e8: "NFC: trf7970a: Handle extra byte in response
to Type 5 RMB commands" from Apr 24, 2015, leads to the following
Smatch complaint:
drivers/nfc/trf7970a.c:632 trf7970a_send_upstream()
error: we previously assumed 'trf->rx_skb' could be null (see line 613)
drivers/nfc/trf7970a.c
612
613 if (trf->rx_skb && !IS_ERR(trf->rx_skb) && !trf->aborting)
^^^^^^^^^^^
Check for NULL.
614 print_hex_dump_debug("trf7970a rx data: ", DUMP_PREFIX_NONE,
615 16, 1, trf->rx_skb->data, trf->rx_skb->len,
616 false);
617
618 trf->state = TRF7970A_ST_IDLE;
619
620 if (trf->aborting) {
621 dev_dbg(trf->dev, "Abort process complete\n");
622
623 if (!IS_ERR(trf->rx_skb)) {
624 kfree_skb(trf->rx_skb);
625 trf->rx_skb = ERR_PTR(-ECANCELED);
626 }
627
628 trf->aborting = false;
629 }
630
631 if (trf->adjust_resp_len) {
632 skb_trim(trf->rx_skb, trf->rx_skb->len - 1);
^^^^^^^^^^^
Patch introduces unchecked dereference inside skb_trim().
633 trf->adjust_resp_len = false;
634 }
regards,
dan carpenter
reply other threads:[~2015-06-23 13:07 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150623130703.GA27051@mwanda \
--to=dan.carpenter@oracle.com \
--cc=linux-wireless@vger.kernel.org \
--cc=mgreer@animalcreek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox