From: Dan Carpenter <dan.carpenter@oracle.com>
To: Dean Lee <dean.lee@atmel.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-wireless@vger.kernel.org, rachel.kim@atmel.com,
chris.park@atmel.com, nicolas.ferre@atmel.com,
johnny.kim@atmel.com
Subject: Re: [PATCH 6/6] staging: wilc1000: delete unused value.
Date: Tue, 30 Jun 2015 12:40:52 +0300 [thread overview]
Message-ID: <20150630094052.GP28762@mwanda> (raw)
In-Reply-To: <1435653278-5168-6-git-send-email-dean.lee@atmel.com>
On Tue, Jun 30, 2015 at 05:34:38PM +0900, Dean Lee wrote:
> diff --git a/drivers/staging/wilc1000/linux_wlan.c b/drivers/staging/wilc1000/linux_wlan.c
> index 1b8991a..0772292 100644
> --- a/drivers/staging/wilc1000/linux_wlan.c
> +++ b/drivers/staging/wilc1000/linux_wlan.c
> @@ -1946,7 +1946,7 @@ int wilc1000_wlan_init(struct net_device *dev, perInterface_wlan_t *p_nic)
>
> wilc_bus_set_max_speed();
>
> - if (g_linux_wlan->oup.wlan_cfg_get(1, WID_FIRMWARE_VERSION, 1, 0)) {
> + if (g_linux_wlan->oup.wlan_cfg_get(1, WID_FIRMWARE_VERSION, 1, NULL)) {
> int size;
> char Firmware_ver[20];
> size = g_linux_wlan->oup.wlan_cfg_get_value(
This change is not in the patch description.
regards,
dan carpenter
next prev parent reply other threads:[~2015-06-30 9:41 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-30 8:34 [PATCH 1/6] staging: wilc1000: modify build error Dean Lee
2015-06-30 8:34 ` [PATCH 2/6] staging: wilc1000: delete 'WILC_WFIDrvHandle' structure Dean Lee
2015-07-07 2:21 ` Greg KH
2015-06-30 8:34 ` [PATCH 3/6] staging: wilc1000: rework driver handler Dean Lee
2015-06-30 9:27 ` Dan Carpenter
2015-06-30 8:34 ` [PATCH 4/6] staging: wilc1000: rework address value Dean Lee
2015-06-30 9:31 ` Dan Carpenter
2015-06-30 16:42 ` Greg KH
2015-06-30 8:34 ` [PATCH 5/6] staging: wilc1000: fix initialize warning issue Dean Lee
2015-06-30 9:39 ` Dan Carpenter
2015-07-07 2:19 ` Greg KH
2015-06-30 8:34 ` [PATCH 6/6] staging: wilc1000: delete unused value Dean Lee
2015-06-30 9:40 ` Dan Carpenter [this message]
2015-07-07 2:20 ` Greg KH
2015-06-30 8:50 ` [PATCH 1/6] staging: wilc1000: modify build error Dan Carpenter
[not found] ` <55925A25.8030608@atmel.com>
2015-06-30 9:10 ` Dan Carpenter
2015-06-30 16:42 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150630094052.GP28762@mwanda \
--to=dan.carpenter@oracle.com \
--cc=chris.park@atmel.com \
--cc=dean.lee@atmel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=johnny.kim@atmel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
--cc=rachel.kim@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).