From: "Michael Büsch" <m@bues.ch>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Nik Nyby <nikolas@gnu.org>,
linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org
Subject: Re: [PATCH] b43: Fix typo in function name
Date: Tue, 30 Jun 2015 17:15:57 +0200 [thread overview]
Message-ID: <20150630171557.17782835@wiggum> (raw)
In-Reply-To: <5591F0F4.3010008@lwfinger.net>
[-- Attachment #1: Type: text/plain, Size: 892 bytes --]
On Mon, 29 Jun 2015 20:29:24 -0500
Larry Finger <Larry.Finger@lwfinger.net> wrote:
> On 06/29/2015 07:45 PM, Nik Nyby wrote:
> > This fixes a typo in the "b43_lo_g_maintenance_work" function
> > name.
> >
> > Signed-off-by: Nik Nyby <nikolas@gnu.org>
> > ---
> > drivers/net/wireless/b43/lo.c | 4 ++--
> > drivers/net/wireless/b43/lo.h | 2 +-
> > drivers/net/wireless/b43/phy_g.c | 2 +-
> > 3 files changed, 4 insertions(+), 4 deletions(-)
>
> This patch is OK; however, can there really be a typo in a function name? How do
> you ever know that the author did not mean to use a name that looks like a typo?
>
> Please be careful with these.
>
> Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Nice finding.
Me as the original author of that mess gets a brown paper bag and acks
this.
Acked-by: Michael Buesch <m@bues.ch>
--
Michael
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-06-30 15:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-30 0:45 [PATCH] b43: Fix typo in function name Nik Nyby
2015-06-30 1:29 ` Larry Finger
2015-06-30 15:15 ` Michael Büsch [this message]
2015-07-21 13:53 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150630171557.17782835@wiggum \
--to=m@bues.ch \
--cc=Larry.Finger@lwfinger.net \
--cc=b43-dev@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=nikolas@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).