From: Greg KH <gregkh@linuxfoundation.org>
To: Johnny Kim <johnny.kim@atmel.com>
Cc: devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org,
chris.park@atmel.com, rachel.kim@atmel.com, dean.lee@atmel.com,
austin.shin@atmel.com, Nicolas.FERRE@atmel.com,
tony.cho@atmel.com
Subject: Re: [PATCH 2/3] staging: wilc1000: wilc_wlan_cfg_get(): replace integer with void pointer
Date: Tue, 14 Jul 2015 14:12:54 -0700 [thread overview]
Message-ID: <20150714211254.GA11675@kroah.com> (raw)
In-Reply-To: <1436507759-4546-3-git-send-email-johnny.kim@atmel.com>
On Fri, Jul 10, 2015 at 02:55:56PM +0900, Johnny Kim wrote:
> Last argument of wilc_wlan_cfg_get function is actually structure's address.
> This should be changed to be compatible with 64bit machine.
> Because wilc_wlan_cfg_get function is mapped by function pointer later,
> wilc_wlan_oup_t.wlan_cfg_get should be changed together.
>
> tstrWILC_WFIDrv structure is defined after wilc_wlan_oup_t.wlan_cfg_get
> is defined. So, this patch changes the argument to void type pointer.
No, you should never use a void pointer, that indicates the code is
designed wrong.
Please reorder the structures in a .h file if needed, there is nothing
preventing you from doing the right thing here.
Please fix up this whole series and resend, I can't take it as-is,
sorry.
greg k-h
next prev parent reply other threads:[~2015-07-14 21:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-10 5:55 [PATCH 0/3] staging: wilc1000: rework integer value for x64 Johnny Kim
2015-07-10 5:55 ` [PATCH 1/3] staging: wilc1000: wilc_wlan_cfg_commit(): replace integer with pointer Johnny Kim
2015-07-10 6:20 ` Julian Calaby
2015-07-10 7:58 ` Johnny Kim
2015-07-10 10:05 ` Julian Calaby
2015-07-10 5:55 ` [PATCH 2/3] staging: wilc1000: wilc_wlan_cfg_get(): replace integer with void pointer Johnny Kim
2015-07-10 6:25 ` Julian Calaby
2015-07-10 8:11 ` Johnny Kim
2015-07-10 10:17 ` Julian Calaby
2015-07-14 21:12 ` Greg KH [this message]
2015-07-10 5:55 ` [PATCH 3/3] staging: wilc1000: wilc_wlan_cfg_set(): " Johnny Kim
2015-07-10 6:26 ` Julian Calaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150714211254.GA11675@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Nicolas.FERRE@atmel.com \
--cc=austin.shin@atmel.com \
--cc=chris.park@atmel.com \
--cc=dean.lee@atmel.com \
--cc=devel@driverdev.osuosl.org \
--cc=johnny.kim@atmel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=rachel.kim@atmel.com \
--cc=tony.cho@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).