From: Kalle Valo <kvalo@codeaurora.org>
To: John Linville <linville@tuxdriver.com>
Cc: linux-wireless@vger.kernel.org,
Amitkumar Karwar <akarwar@marvell.com>,
Avinash Patil <patila@marvell.com>,
"John W. Linville" <linville@tuxdriver.com>
Subject: Re: mwifiex: avoid freeing improper pointer inmwifiex_set_wowlan_mef_entry
Date: Tue, 21 Jul 2015 13:44:39 +0000 (UTC) [thread overview]
Message-ID: <20150721134439.30BC614106A@smtp.codeaurora.org> (raw)
In-Reply-To: <1435085145-9668-1-git-send-email-linville@tuxdriver.com>
> mwifiex_set_wowlan_mef_entry attempts to free a passed-in pointer in
> case of an error. The only caller (mwifiex_set_mef_filter) passes that
> pointer as an offset into allocated memory, so any attempt to free that
> will not be the actual allocated pointer.
>
> Address this by changing mwifiex_set_wowlan_mef_entry to not do any
> free, and to cause mwifiex_set_mef_filter to do the appropriate free if
> the call to mwifiex_set_wowlan_mef_entry fails.
>
> Coverity CID #1295879
>
> Signed-off-by: John W. Linville <linville@tuxdriver.com>
> Acked-by: Amitkumar Karwar <akarwar@marvell.com>
Thanks, applied to wireless-drivers-next.git.
Kalle Valo
prev parent reply other threads:[~2015-07-21 13:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-23 18:45 [PATCH] mwifiex: avoid freeing improper pointer in mwifiex_set_wowlan_mef_entry John W. Linville
2015-06-24 13:05 ` Amitkumar Karwar
2015-07-21 13:44 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150721134439.30BC614106A@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=akarwar@marvell.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=patila@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).