* [PATCH v2 0/3] mwifiex p2p fixes
@ 2015-07-16 15:05 Amitkumar Karwar
2015-07-16 15:05 ` [PATCH v2 1/3] mwifiex: add bss mode TLV to extended scan command Amitkumar Karwar
2015-07-16 15:05 ` [PATCH v2 2/3] mwifiex: use maximum ssid length as 0xfe for p2p Amitkumar Karwar
0 siblings, 2 replies; 4+ messages in thread
From: Amitkumar Karwar @ 2015-07-16 15:05 UTC (permalink / raw)
To: linux-wireless; +Cc: Amitkumar Karwar
This patch series resolves couple of issues observed during p2p
opeations.
v2: Removed redundant tag "UPSTREAM:" in patch title.
Aniket Nagarnaik (3):
mwifiex: add bss mode TLV to extended scan command
mwifiex: use maximum ssid length as 0xfe for p2p
mwifiex: correct p2p and station interface counters
drivers/net/wireless/mwifiex/cfg80211.c | 4 +++-
drivers/net/wireless/mwifiex/fw.h | 6 ++++++
drivers/net/wireless/mwifiex/scan.c | 14 ++++++++++++++
3 files changed, 23 insertions(+), 1 deletion(-)
--
1.8.1.4
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2 1/3] mwifiex: add bss mode TLV to extended scan command
2015-07-16 15:05 [PATCH v2 0/3] mwifiex p2p fixes Amitkumar Karwar
@ 2015-07-16 15:05 ` Amitkumar Karwar
2015-07-21 15:10 ` [v2,1/3] " Kalle Valo
2015-07-16 15:05 ` [PATCH v2 2/3] mwifiex: use maximum ssid length as 0xfe for p2p Amitkumar Karwar
1 sibling, 1 reply; 4+ messages in thread
From: Amitkumar Karwar @ 2015-07-16 15:05 UTC (permalink / raw)
To: linux-wireless; +Cc: Aniket Nagarnaik, Amitkumar Karwar
From: Aniket Nagarnaik <aniketn@marvell.com>
We are setting BSS mode as ANY so that firmware will provide
all types of scan entries.
Signed-off-by: Aniket Nagarnaik <aniketn@marvell.com>
Signed-off-by: Amitkumar Karwar <akarwar@marvell.com>
---
drivers/net/wireless/mwifiex/fw.h | 6 ++++++
drivers/net/wireless/mwifiex/scan.c | 10 ++++++++++
2 files changed, 16 insertions(+)
diff --git a/drivers/net/wireless/mwifiex/fw.h b/drivers/net/wireless/mwifiex/fw.h
index cd09051..59662bb 100644
--- a/drivers/net/wireless/mwifiex/fw.h
+++ b/drivers/net/wireless/mwifiex/fw.h
@@ -177,6 +177,7 @@ enum MWIFIEX_802_11_PRIVACY_FILTER {
#define TLV_TYPE_CHANNEL_STATS (PROPRIETARY_TLV_BASE_ID + 198)
#define TLV_BTCOEX_WL_AGGR_WINSIZE (PROPRIETARY_TLV_BASE_ID + 202)
#define TLV_BTCOEX_WL_SCANTIME (PROPRIETARY_TLV_BASE_ID + 203)
+#define TLV_TYPE_BSS_MODE (PROPRIETARY_TLV_BASE_ID + 206)
#define MWIFIEX_TX_DATA_BUF_SIZE_2K 2048
@@ -1370,6 +1371,11 @@ struct host_cmd_ds_802_11_scan_ext {
u8 tlv_buffer[1];
} __packed;
+struct mwifiex_ie_types_bss_mode {
+ struct mwifiex_ie_types_header header;
+ u8 bss_mode;
+} __packed;
+
struct mwifiex_ie_types_bss_scan_rsp {
struct mwifiex_ie_types_header header;
u8 bssid[ETH_ALEN];
diff --git a/drivers/net/wireless/mwifiex/scan.c b/drivers/net/wireless/mwifiex/scan.c
index baf9715..ef2bef8 100644
--- a/drivers/net/wireless/mwifiex/scan.c
+++ b/drivers/net/wireless/mwifiex/scan.c
@@ -823,6 +823,7 @@ mwifiex_config_scan(struct mwifiex_private *priv,
int i;
u8 ssid_filter;
struct mwifiex_ie_types_htcap *ht_cap;
+ struct mwifiex_ie_types_bss_mode *bss_mode;
/* The tlv_buf_len is calculated for each scan command. The TLVs added
in this routine will be preserved since the routine that sends the
@@ -968,6 +969,15 @@ mwifiex_config_scan(struct mwifiex_private *priv,
else
*max_chan_per_scan = MWIFIEX_DEF_CHANNELS_PER_SCAN_CMD;
+ if (adapter->ext_scan) {
+ bss_mode = (struct mwifiex_ie_types_bss_mode *)tlv_pos;
+ bss_mode->header.type = cpu_to_le16(TLV_TYPE_BSS_MODE);
+ bss_mode->header.len = cpu_to_le16(sizeof(bss_mode->bss_mode));
+ bss_mode->bss_mode = scan_cfg_out->bss_mode;
+ tlv_pos += sizeof(bss_mode->header) +
+ le16_to_cpu(bss_mode->header.len);
+ }
+
/* If the input config or adapter has the number of Probes set,
add tlv */
if (num_probes) {
--
1.8.1.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v2 2/3] mwifiex: use maximum ssid length as 0xfe for p2p
2015-07-16 15:05 [PATCH v2 0/3] mwifiex p2p fixes Amitkumar Karwar
2015-07-16 15:05 ` [PATCH v2 1/3] mwifiex: add bss mode TLV to extended scan command Amitkumar Karwar
@ 2015-07-16 15:05 ` Amitkumar Karwar
1 sibling, 0 replies; 4+ messages in thread
From: Amitkumar Karwar @ 2015-07-16 15:05 UTC (permalink / raw)
To: linux-wireless; +Cc: Aniket Nagarnaik, Amitkumar Karwar
From: Aniket Nagarnaik <aniketn@marvell.com>
0xfe is basically a magic number used to ask firmware match
provided string in a SSID. In this case, firmware will
return scan results containing"DIRECT-" string.
Signed-off-by: Aniket Nagarnaik <aniketn@marvell.com>
Signed-off-by: Amitkumar Karwar <akarwar@marvell.com>
---
drivers/net/wireless/mwifiex/scan.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/net/wireless/mwifiex/scan.c b/drivers/net/wireless/mwifiex/scan.c
index ef2bef8..ef8da8e 100644
--- a/drivers/net/wireless/mwifiex/scan.c
+++ b/drivers/net/wireless/mwifiex/scan.c
@@ -909,6 +909,10 @@ mwifiex_config_scan(struct mwifiex_private *priv,
wildcard_ssid_tlv->max_ssid_length =
IEEE80211_MAX_SSID_LEN;
+ if (!memcmp(user_scan_in->ssid_list[i].ssid,
+ "DIRECT-", 7))
+ wildcard_ssid_tlv->max_ssid_length = 0xfe;
+
memcpy(wildcard_ssid_tlv->ssid,
user_scan_in->ssid_list[i].ssid, ssid_len);
--
1.8.1.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [v2,1/3] mwifiex: add bss mode TLV to extended scan command
2015-07-16 15:05 ` [PATCH v2 1/3] mwifiex: add bss mode TLV to extended scan command Amitkumar Karwar
@ 2015-07-21 15:10 ` Kalle Valo
0 siblings, 0 replies; 4+ messages in thread
From: Kalle Valo @ 2015-07-21 15:10 UTC (permalink / raw)
To: Amitkumar Karwar; +Cc: linux-wireless, Aniket Nagarnaik, Amitkumar Karwar
> From: Aniket Nagarnaik <aniketn@marvell.com>
>
> We are setting BSS mode as ANY so that firmware will provide
> all types of scan entries.
>
> Signed-off-by: Aniket Nagarnaik <aniketn@marvell.com>
> Signed-off-by: Amitkumar Karwar <akarwar@marvell.com>
Thanks, 3 patches applied to wireless-drivers-next.git:
40d7412b56f0 mwifiex: add bss mode TLV to extended scan command
0c6303cc0695 mwifiex: use maximum ssid length as 0xfe for p2p
e79801ffe9c8 mwifiex: correct p2p and station interface counters
Kalle Valo
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-07-21 15:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-16 15:05 [PATCH v2 0/3] mwifiex p2p fixes Amitkumar Karwar
2015-07-16 15:05 ` [PATCH v2 1/3] mwifiex: add bss mode TLV to extended scan command Amitkumar Karwar
2015-07-21 15:10 ` [v2,1/3] " Kalle Valo
2015-07-16 15:05 ` [PATCH v2 2/3] mwifiex: use maximum ssid length as 0xfe for p2p Amitkumar Karwar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).