From: Dan Carpenter <dan.carpenter@oracle.com>
To: Chaehyun Lim <chaehyun.lim@gmail.com>
Cc: gregkh@linuxfoundation.org, rachel.kim@atmel.com,
dean.lee@atmel.com, chris.park@atmel.com,
devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org,
johnny.kim@atmel.com
Subject: Re: [PATCH V2 1/3] staging: wilc1000: coreconfigurator.c: remove WILC_MALLOC
Date: Fri, 24 Jul 2015 03:44:55 +0300 [thread overview]
Message-ID: <20150724004454.GU5371@mwanda> (raw)
In-Reply-To: <1437695755-9731-1-git-send-email-chaehyun.lim@gmail.com>
On Fri, Jul 24, 2015 at 08:55:53AM +0900, Chaehyun Lim wrote:
> Use kmalloc and kmalloc_array instead of WILC_MALLOC.
>
> Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
> ---
> V2: Use GFP_KERNEL flag instead of GFP_ATOMIC
This is probably the correct thing but how did you check that we aren't
holding a spin_lock or in IRQ context?
regards,
dan carpenter
next prev parent reply other threads:[~2015-07-24 0:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-23 23:55 [PATCH V2 1/3] staging: wilc1000: coreconfigurator.c: remove WILC_MALLOC Chaehyun Lim
2015-07-23 23:55 ` [PATCH V3 2/3] staging: wilc1000: coreconfigurator.c: add kmalloc error check Chaehyun Lim
2015-07-23 23:55 ` [PATCH V3 3/3] staging: wilc1000: coreconfigurator.c: fix " Chaehyun Lim
2015-07-24 0:44 ` Dan Carpenter [this message]
[not found] ` <55B59D8D.6010805@atmel.com>
2015-07-27 7:52 ` [PATCH V2 1/3] staging: wilc1000: coreconfigurator.c: remove WILC_MALLOC Dan Carpenter
2015-07-29 20:45 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150724004454.GU5371@mwanda \
--to=dan.carpenter@oracle.com \
--cc=chaehyun.lim@gmail.com \
--cc=chris.park@atmel.com \
--cc=dean.lee@atmel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=johnny.kim@atmel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=rachel.kim@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).