Linux wireless drivers development
 help / color / mirror / Atom feed
From: "Joglekar, Tejas (T.)" <tjogleka@visteon.com>
To: Jes Sorensen <Jes.Sorensen@redhat.com>
Cc: "Larry.Finger@lwfinger.net" <Larry.Finger@lwfinger.net>,
	"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging:rtl8723au:core:rtw_sreset.c:Fix for space related error
Date: Sun, 26 Jul 2015 16:36:07 +0000	[thread overview]
Message-ID: <20150726163600.GA3341@tejas-asus.domain.name> (raw)
In-Reply-To: <wrfjd1zful94.fsf@redhat.com>

On Sun, Jul 26, 2015 at 09:00:23AM -0400, Jes Sorensen wrote:
> "Joglekar, Tejas (T.)" <tjogleka@visteon.com> writes:
> > From: Joglekar Tejas <tjogleka@visteon.com>
> >
> > This patch fixes the error given by checkpatch.pl
> >
> > Signed-off-by: Joglekar Tejas <tjogleka@visteon.com>
> > ---
> >  drivers/staging/rtl8723au/core/rtw_sreset.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/rtl8723au/core/rtw_sreset.c b/drivers/staging/rtl8723au/core/rtw_sreset.c
> > index 29a29d9..48b7723 100644
> > --- a/drivers/staging/rtl8723au/core/rtw_sreset.c
> > +++ b/drivers/staging/rtl8723au/core/rtw_sreset.c
> > @@ -71,7 +71,7 @@ static void sreset_restore_security_station(struct rtw_adapter *padapter)
> >  			/* pairwise key */
> >  			rtw_setstakey_cmd23a(padapter, (unsigned char *)psta, true);
> >  			/* group key */
> > -			rtw_set_key23a(padapter,&padapter->securitypriv, padapter->securitypriv.dot118021XGrpKeyid, 0);
> > +			rtw_set_key23a(padapter, &padapter->securitypriv, padapter->securitypriv.dot118021XGrpKeyid, 0);
> >  		}
> >  	}
> >  }
> 
> NAK!
> 
> If you are 'fixing' checkpatch 'errors', do it properly and break down
> the line and solve the 80 character limit 'error' as well.
> 
> Jes

Jes ,
Sure, I will break down the line, and remove the 80 character limit issue , before resending the patch.

Thanks & Regards,
Tejas Joglekar

      reply	other threads:[~2015-07-26 16:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-26  7:40 [PATCH] staging:rtl8723au:core:rtw_sreset.c:Fix for space related error Joglekar, Tejas (T.)
2015-07-26 13:00 ` Jes Sorensen
2015-07-26 16:36   ` Joglekar, Tejas (T.) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150726163600.GA3341@tejas-asus.domain.name \
    --to=tjogleka@visteon.com \
    --cc=Jes.Sorensen@redhat.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox