[PATCH] staging: wilc1000: host_interface.c: Fix build warning

[PATCH] staging: wilc1000: host_interface.c: Fix build warning

[Chandra S Gorentla]

Fixed - warning: ‘*((void *)&strHostIFmsg+4).pu8Head’ may be used uninitialized 

Signed-off-by: Chandra S Gorentla <csgorentla@gmail.com>
---
 drivers/staging/wilc1000/host_interface.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
index c089e73..f610903 100644
--- a/drivers/staging/wilc1000/host_interface.c
+++ b/drivers/staging/wilc1000/host_interface.c
@@ -7113,7 +7113,7 @@ s32 host_int_add_beacon(WILC_WFIDrvHandle hWFIDrv, u32 u32Interval,
 {
 	s32 s32Error = WILC_SUCCESS;
 	tstrWILC_WFIDrv *pstrWFIDrv = (tstrWILC_WFIDrv *)hWFIDrv;
-	tstrHostIFmsg strHostIFmsg;
+	tstrHostIFmsg strHostIFmsg = {};
 	tstrHostIFSetBeacon *pstrSetBeaconParam = &strHostIFmsg.uniHostIFmsgBody.strHostIFSetBeacon;
 
 	if (pstrWFIDrv == NULL)
-- 
2.4.5

Re: [PATCH] staging: wilc1000: host_interface.c: Fix build warning

[Dan Carpenter]

On Wed, Jul 29, 2015 at 07:36:59PM +0530, Chandra S Gorentla wrote:
> Fixed - warning: ‘*((void *)&strHostIFmsg+4).pu8Head’ may be used uninitialized 
> 

I can't reproduce this warning and the original code looks fine to me.

When you say the word "fix" it means the code is buggy.  Otherwise we
are just silencing warnings or cleaning up code.  It's not clear from
the patch description what is happening here, is it a bug or a warning
only?

regards,
dan carpenter

Re: [PATCH] staging: wilc1000: host_interface.c: Fix build warning

[Chandra Gorentla]

On Wed, Jul 29, 2015 at 05:20:37PM +0300, Dan Carpenter wrote:
> On Wed, Jul 29, 2015 at 07:36:59PM +0530, Chandra S Gorentla wrote:
> > Fixed - warning: ‘*((void *)&strHostIFmsg+4).pu8Head’ may be used uninitialized 
> > 
> 
> I can't reproduce this warning and the original code looks fine to me.
> 
> When you say the word "fix" it means the code is buggy.  Otherwise we
> are just silencing warnings or cleaning up code.  It's not clear from
> the patch description what is happening here, is it a bug or a warning
> only?
> 
> regards,
> dan carpenter
> 
Following is the build log -
----
gcs@gcs-HP-Compaq-nx6320:~/linux/git-linux$ make ARCH=arm CROSS_COMPILE=arm-linux-gnueabi- SUBFOLDER=drivers/staging/wilc1000/
  CHK     include/config/kernel.release
  CHK     include/generated/uapi/linux/version.h
  CHK     include/generated/utsrelease.h
make[1]: `include/generated/mach-types.h' is up to date.
  CHK     include/generated/bounds.h
  CHK     include/generated/timeconst.h
  CHK     include/generated/asm-offsets.h
  CALL    scripts/checksyscalls.sh
<stdin>:1298:2: warning: #warning syscall userfaultfd not implemented [-Wcpp]
  CHK     include/generated/compile.h
  CHK     kernel/config_data.h
  CC [M]  drivers/staging/wilc1000/host_interface.o
drivers/staging/wilc1000/host_interface.c: In function ‘host_int_add_beacon’:
drivers/staging/wilc1000/host_interface.c:7116:16: warning: ‘*((void *)&strHostIFmsg+4).pu8Head’ may be used uninitialized in this function [-Wuninitialized]
  LD [M]  drivers/staging/wilc1000/wilc1000.o
  Kernel: arch/arm/boot/Image is ready
  Kernel: arch/arm/boot/zImage is ready
  Building modules, stage 2.
  MODPOST 85 modules
  CC      drivers/staging/wilc1000/wilc1000.mod.o
  LDFINAL [M]  drivers/staging/wilc1000/wilc1000.ko
gcs@gcs-HP-Compaq-nx6320:~/linux/git-linux$
----
Proposed fix removes this warning.

Currently the 'wilc1000' driver in staging is marked as BROKEN in its
KConfig file at 'drivers/staging/wilc1000/'.  I had to remove this line
to execute the above make command.

Thanks,
chandra

Re: [PATCH] staging: wilc1000: host_interface.c: Fix build warning

[Greg KH]

On Wed, Jul 29, 2015 at 07:36:59PM +0530, Chandra S Gorentla wrote:
> Fixed - warning: ‘*((void *)&strHostIFmsg+4).pu8Head’ may be used uninitialized 

The warning is incorrect, look at the code, I don't see anything wrong
with it.  I suggest upgrading to a newer version of gcc that doesn't
report incorrect things like this, gcc 5.2 works fine for me here.

greg k-h