From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Tony Cho <tony.cho@atmel.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
rachel.kim@atmel.com, chris.park@atmel.com,
austin.shin@atmel.com, linux-wireless@vger.kernel.org,
johnny.kim@atmel.com, Nicolas.FERRE@atmel.com,
robin.hwang@atmel.com, jude.lee@atmel.com, leo.kim@atmel.com
Subject: Re: [PATCH V2 3/5] staging: wilc1000: remove warnings on missing blank line
Date: Thu, 30 Jul 2015 17:40:32 +0530 [thread overview]
Message-ID: <20150730121032.GB12823@sudip-pc> (raw)
In-Reply-To: <1438247414-19708-4-git-send-email-tony.cho@atmel.com>
On Thu, Jul 30, 2015 at 06:10:12PM +0900, Tony Cho wrote:
> This patch removes the warnings reported by checkpatch.pl on missing
> a blank line after declarations.
>
> Signed-off-by: Tony Cho <tony.cho@atmel.com>
> ---
> V2: This patch doesn't have a difference with the first one. However,
> it's resent becasue not accepted with the 9th patch.
> ---
> drivers/staging/wilc1000/wilc_sdio.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/wilc1000/wilc_sdio.c b/drivers/staging/wilc1000/wilc_sdio.c
> index ee1cbd1..50be2a1 100644
> --- a/drivers/staging/wilc1000/wilc_sdio.c
> +++ b/drivers/staging/wilc1000/wilc_sdio.c
> @@ -780,6 +780,7 @@ static int sdio_clear_int_ext(uint32_t val)
>
> if (g_sdio.has_thrpt_enh3) {
> uint32_t reg;
> +
> reg = val & ((1 << MAX_NUN_INT_THRPT_ENH2) - 1);
>
> /* select VMM table 0 */
This patch will not apply. After your first patch (1/5)
if (g_sdio.has_thrpt_enh3) has become if(g_sdio.has_thrpt_enh3).
regards
sudip
next prev parent reply other threads:[~2015-07-30 12:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-30 9:10 [PATCH 0/5] 2nd patch for illegal coding style Tony Cho
2015-07-30 9:10 ` [PATCH V2 1/5] staging: wilc1000: #ifdef conditionals cover entire functions Tony Cho
2015-07-30 9:19 ` Johnny Kim
2015-07-30 11:56 ` Sudip Mukherjee
[not found] ` <55BAEB08.8090705@atmel.com>
2015-07-31 3:48 ` Greg KH
2015-07-30 9:10 ` [PATCH V2 2/5] staging: wilc1000: remove unnecessary blank lines Tony Cho
2015-07-30 9:10 ` [PATCH V2 3/5] staging: wilc1000: remove warnings on missing blank line Tony Cho
2015-07-30 12:10 ` Sudip Mukherjee [this message]
2015-07-30 9:10 ` [PATCH V2 4/5] staging: wilc1000: remove errors on required space Tony Cho
2015-07-30 9:10 ` [PATCH V2 5/5] staging: wilc1000: remove unused functions Tony Cho
2015-07-31 3:49 ` [PATCH 0/5] 2nd patch for illegal coding style Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150730121032.GB12823@sudip-pc \
--to=sudipm.mukherjee@gmail.com \
--cc=Nicolas.FERRE@atmel.com \
--cc=austin.shin@atmel.com \
--cc=chris.park@atmel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=johnny.kim@atmel.com \
--cc=jude.lee@atmel.com \
--cc=leo.kim@atmel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=rachel.kim@atmel.com \
--cc=robin.hwang@atmel.com \
--cc=tony.cho@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox