From: Dan Carpenter <dan.carpenter@oracle.com>
To: Chaehyun Lim <chaehyun.lim@gmail.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
rachel.kim@atmel.com, dean.lee@atmel.com, chris.park@atmel.com,
devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org,
johnny.kim@atmel.com
Subject: Re: [RESEND V2 0/3] cover letter of wilc1000 patches
Date: Thu, 30 Jul 2015 15:18:17 +0300 [thread overview]
Message-ID: <20150730121817.GN5180@mwanda> (raw)
In-Reply-To: <CAKV=isuiu4GeYxPFpwqSn8io-uq7hz53tiBX9dmh62b4rvRA=g@mail.gmail.com>
On Thu, Jul 30, 2015 at 09:03:48PM +0900, Chaehyun Lim wrote:
> On Thu, Jul 30, 2015 at 8:41 PM, Chaehyun Lim <chaehyun.lim@gmail.com> wrote:
> >
> > First patch has 4 sites of kmalloc change in coreconfigurator.c
> > First one, it is used for gps8ConfigPacket at CoreconfiguratorInit and CoreConfiguratorDeInit.
> > I think it should be removed next time because I cannot find anywhere to use it.
> > Then, it is okay to change flag as GFP_KERNEL.
> >
> > Other three changes are used to handle host interface message within a kernel thread.
> > The manipulation of host interface message is not called on IRQ context and I could not
> > find any spin lock inside function.
> >
This information is good information and it should be in the patch
description.
regards,
dan carpenter
prev parent reply other threads:[~2015-07-30 12:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-30 11:41 [RESEND V2 0/3] cover letter of wilc1000 patches Chaehyun Lim
2015-07-30 11:41 ` [RESEND V2 1/3] staging: wilc1000: coreconfigurator.c: remove WILC_MALLOC Chaehyun Lim
2015-07-30 11:41 ` [RESEND V2 2/3] staging: wilc1000: coreconfigurator.c: add kmalloc error check Chaehyun Lim
2015-07-30 11:41 ` [RESEND V2 3/3] staging: wilc1000: coreconfigurator.c: fix " Chaehyun Lim
2015-07-30 12:03 ` [RESEND V2 0/3] cover letter of wilc1000 patches Chaehyun Lim
2015-07-30 12:18 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150730121817.GN5180@mwanda \
--to=dan.carpenter@oracle.com \
--cc=chaehyun.lim@gmail.com \
--cc=chris.park@atmel.com \
--cc=dean.lee@atmel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=johnny.kim@atmel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=rachel.kim@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox