From: Greg KH <gregkh@linuxfoundation.org>
To: Tony Cho <tony.cho@atmel.com>
Cc: devel@driverdev.osuosl.org, rachel.kim@atmel.com,
chris.park@atmel.com, austin.shin@atmel.com,
linux-wireless@vger.kernel.org, johnny.kim@atmel.com,
Nicolas.FERRE@atmel.com, robin.hwang@atmel.com,
jude.lee@atmel.com, leo.kim@atmel.com
Subject: Re: [PATCH 28/28] staging: wilc1000: change data type of variable
Date: Fri, 31 Jul 2015 13:48:40 -0700 [thread overview]
Message-ID: <20150731204840.GB1650@kroah.com> (raw)
In-Reply-To: <1438328316-30197-29-git-send-email-tony.cho@atmel.com>
On Fri, Jul 31, 2015 at 04:38:36PM +0900, Tony Cho wrote:
> From: glen lee <glen.lee@atmel.com>
>
> drvHandler of u32 type is used to handle integer type pointer operation which
> cause build warnings.
> To use integer type varialbe as pointer, drvHandler data type need to be changed
> with uintptr_t type.
>
> drivers/staging/wilc1000/host_interface.c: In function ‘NetworkInfoReceived’:
> drivers/staging/wilc1000/host_interface.c:6767:15: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
> pstrWFIDrv = (tstrWILC_WFIDrv *)drvHandler;
> ^
> drivers/staging/wilc1000/host_interface.c: In function ‘GnrlAsyncInfoReceived’:
> drivers/staging/wilc1000/host_interface.c:6819:15: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
> pstrWFIDrv = (tstrWILC_WFIDrv *)drvHandler;
> ^
> drivers/staging/wilc1000/host_interface.c: In function ‘host_int_ScanCompleteReceived’:
> drivers/staging/wilc1000/host_interface.c:6878:15: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
> pstrWFIDrv = (tstrWILC_WFIDrv *)drvHandler;
>
> Signed-off-by: glen lee <glen.lee@atmel.com>
> Signed-off-by: Tony Cho <tony.cho@atmel.com>
> ---
> drivers/staging/wilc1000/host_interface.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
> index b36f98c..668e47e 100644
> --- a/drivers/staging/wilc1000/host_interface.c
> +++ b/drivers/staging/wilc1000/host_interface.c
> @@ -6760,7 +6760,7 @@ void NetworkInfoReceived(u8 *pu8Buffer, u32 u32Length)
> {
> s32 s32Error = WILC_SUCCESS;
> tstrHostIFmsg strHostIFmsg;
> - u32 drvHandler;
> + uintptr_t drvHandler;
This isn't a valid kernel type, use "unsigned int *" if that is what you mean.
thanks,
greg k-h
next prev parent reply other threads:[~2015-07-31 20:48 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-31 7:38 [PATCH 00/28] removing the compile warnings for 64-bit Tony Cho
2015-07-31 7:38 ` [PATCH 01/28] staging: wilc1000: change type of driver handler in host interface msg Tony Cho
2015-07-31 20:46 ` Greg KH
2015-07-31 7:38 ` [PATCH 02/28] staging: wilc1000: change void type of argument with WILC_WFIDrvHandle Tony Cho
2015-07-31 20:46 ` Greg KH
2015-07-31 7:38 ` [PATCH 03/28] staging: wilc1000: move structure WILC_WFIDrvHandle into wilc_wlan_if.h Tony Cho
2015-07-31 7:38 ` [PATCH 04/28] staging: wilc1000: change type of argument 5 in SendConfigPkt Tony Cho
2015-07-31 7:38 ` [PATCH 05/28] staging: wilc1000: remove unnecessary type cast Tony Cho
2015-07-31 7:38 ` [PATCH 06/28] staging: wilc1000: chage driver handler variable in SendConfigPkt Tony Cho
2015-07-31 7:38 ` [PATCH 07/28] staging: wilc1000: remove unused variables Tony Cho
2015-07-31 7:38 ` [PATCH 08/28] staging: wilc1000: change drvHandler type in wlan_cfg_get Tony Cho
2015-07-31 7:38 ` [PATCH 09/28] staging: wilc1000: change drvHandler type in wlan_cfg_set Tony Cho
2015-07-31 7:38 ` [PATCH 10/28] staging: wilc1000: change driver handle variable Tony Cho
2015-07-31 7:38 ` [PATCH 11/28] staging: wilc1000: fix incompatible type in assignment warning Tony Cho
2015-07-31 7:38 ` [PATCH 12/28] staging: wilc1000: change type of driver handler in tstrInterfaceInfo Tony Cho
2015-07-31 7:38 ` [PATCH 13/28] staging: wilc1000: change type of argument in host_int_set_wfi_drv_handler Tony Cho
2015-07-31 7:38 ` [PATCH 14/28] staging: wilc1000: remove unnecessary type cast " Tony Cho
2015-07-31 7:38 ` [PATCH 15/28] staging: wilc1000: fix cast from pointer to integer warning Tony Cho
2015-07-31 7:38 ` [PATCH 16/28] staging: wilc1000: change type of variable Tony Cho
2015-07-31 7:38 ` [PATCH 17/28] staging: wilc1000: fix comparison between different type warning Tony Cho
2015-07-31 7:38 ` [PATCH 18/28] staging: wilc1000: change pstrWFIDrv with drvHandler Tony Cho
2015-07-31 7:38 ` [PATCH 19/28] staging: wilc1000: change type of variable in tstrHostIfSetDrvHandler Tony Cho
2015-07-31 7:38 ` [PATCH 20/28] staging: wilc1000: remove unnecessary type case Tony Cho
2015-07-31 7:38 ` [PATCH 21/28] staging: wilc1000: remove unwanted type cast Tony Cho
2015-07-31 7:38 ` [PATCH 22/28] staging: wilc1000: fix passing argument from incompatible type warning Tony Cho
2015-07-31 7:38 ` [PATCH 23/28] staging: wilc1000: change type of parameter in wilc_wlan_cfg_commit Tony Cho
2015-07-31 7:38 ` [PATCH 24/28] staging: wilc1000: fix cast from pointer to integer warning Tony Cho
2015-07-31 20:51 ` Greg KH
2015-07-31 7:38 ` [PATCH 25/28] staging: wilc1000: change cast type from pointer to uintptr_t Tony Cho
2015-07-31 20:50 ` Greg KH
2015-07-31 7:38 ` [PATCH 26/28] staging: wilc1000: remove unused variable Tony Cho
2015-07-31 7:38 ` [PATCH 27/28] staging: wilc1000: fix casting build warning Tony Cho
2015-07-31 7:38 ` [PATCH 28/28] staging: wilc1000: change data type of variable Tony Cho
2015-07-31 20:48 ` Greg KH [this message]
2015-07-31 12:49 ` [PATCH 00/28] removing the compile warnings for 64-bit Sudip Mukherjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150731204840.GB1650@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Nicolas.FERRE@atmel.com \
--cc=austin.shin@atmel.com \
--cc=chris.park@atmel.com \
--cc=devel@driverdev.osuosl.org \
--cc=johnny.kim@atmel.com \
--cc=jude.lee@atmel.com \
--cc=leo.kim@atmel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=rachel.kim@atmel.com \
--cc=robin.hwang@atmel.com \
--cc=tony.cho@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).