* [PATCH] mwifiex: add missing skb_push() in mwifiex_check_uap_capabilties
@ 2015-07-27 12:02 Amitkumar Karwar
2015-08-06 7:19 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Amitkumar Karwar @ 2015-07-27 12:02 UTC (permalink / raw)
To: linux-wireless; +Cc: Amitkumar Karwar, Nishant Sarmukadam
For PCIe/USB chipsets, preallocated skb buffers are reused for
event handling. mwifiex_check_uap_capabilties() performs
skb_pull(). This patch adds missing skb_push() to restore skb's
data pointer/length.
This bug was introduced by commit debfc6008169 ("mwifiex: update
AP WMM settings from BSS_START event")
Signed-off-by: Amitkumar Karwar <akarwar@marvell.com>
Signed-off-by: Nishant Sarmukadam <nishants@marvell.com>
---
drivers/net/wireless/mwifiex/uap_event.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/wireless/mwifiex/uap_event.c b/drivers/net/wireless/mwifiex/uap_event.c
index 7bc1f85..4a07476 100644
--- a/drivers/net/wireless/mwifiex/uap_event.c
+++ b/drivers/net/wireless/mwifiex/uap_event.c
@@ -41,6 +41,8 @@ static int mwifiex_check_uap_capabilties(struct mwifiex_private *priv,
mwifiex_dbg_dump(priv->adapter, EVT_D, "uap capabilties:",
event->data, event->len);
+ skb_push(event, MWIFIEX_BSS_START_EVT_FIX_SIZE);
+
while ((evt_len >= sizeof(tlv_hdr->header))) {
tlv_hdr = (struct mwifiex_ie_types_data *)curr;
tlv_len = le16_to_cpu(tlv_hdr->header.len);
--
1.8.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: mwifiex: add missing skb_push() in mwifiex_check_uap_capabilties
2015-07-27 12:02 [PATCH] mwifiex: add missing skb_push() in mwifiex_check_uap_capabilties Amitkumar Karwar
@ 2015-08-06 7:19 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2015-08-06 7:19 UTC (permalink / raw)
To: Amitkumar Karwar; +Cc: linux-wireless, Amitkumar Karwar, Nishant Sarmukadam
> For PCIe/USB chipsets, preallocated skb buffers are reused for
> event handling. mwifiex_check_uap_capabilties() performs
> skb_pull(). This patch adds missing skb_push() to restore skb's
> data pointer/length.
>
> This bug was introduced by commit debfc6008169 ("mwifiex: update
> AP WMM settings from BSS_START event")
>
> Signed-off-by: Amitkumar Karwar <akarwar@marvell.com>
> Signed-off-by: Nishant Sarmukadam <nishants@marvell.com>
Thanks, applied to wireless-drivers-next.git.
Kalle Valo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-08-06 7:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-27 12:02 [PATCH] mwifiex: add missing skb_push() in mwifiex_check_uap_capabilties Amitkumar Karwar
2015-08-06 7:19 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).