From: Dan Carpenter <dan.carpenter@oracle.com>
To: Chandra Gorentla <csgorentla@gmail.com>
Cc: rachel.kim@atmel.com, dean.lee@atmel.com, chris.park@atmel.com,
gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-wireless@vger.kernel.org, johnny.kim@atmel.com,
linux-kernel@vger.kernel.org, sudipm.mukherjee@gmail.com
Subject: Re: [PATCH] staging: wilc100: Remove pointer and integer comparision
Date: Mon, 10 Aug 2015 21:38:56 +0300 [thread overview]
Message-ID: <20150810183856.GM5180@mwanda> (raw)
In-Reply-To: <20150810174034.GA14776@gcs-HP-Compaq-nx6320>
Warnings are not a bad thing they are a valuable marker to let us know
which code is broken. If we just silence the warning in the laziest
possible way then we are throwing away valuable information. It's
better to leave the warning there so that the next person can fix it
properly.
If you want to leave the code as-is that is absolutely fine with me, but
don't remove the warning until someone can look at this a bit carefully.
regards,
dan carpenter
next prev parent reply other threads:[~2015-08-10 18:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-09 15:20 [PATCH] staging: wilc100: Remove pointer and integer comparision Chandra S Gorentla
2015-08-10 9:39 ` Dan Carpenter
2015-08-10 15:29 ` Chandra Gorentla
2015-08-10 16:27 ` Dan Carpenter
2015-08-10 17:40 ` Chandra Gorentla
2015-08-10 18:38 ` Dan Carpenter [this message]
2015-08-11 15:07 ` Chandra Gorentla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150810183856.GM5180@mwanda \
--to=dan.carpenter@oracle.com \
--cc=chris.park@atmel.com \
--cc=csgorentla@gmail.com \
--cc=dean.lee@atmel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=johnny.kim@atmel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=rachel.kim@atmel.com \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).