From: Kalle Valo <kvalo@codeaurora.org>
To: Jes Sorensen <Jes.Sorensen@redhat.com>
Cc: linux-wireless@vger.kernel.org, mahfouz.saif.elyazal@gmail.com
Subject: Re: orinoco: Do not call wiphy_unregister() from free_orinocodev()
Date: Thu, 13 Aug 2015 12:37:13 +0000 (UTC) [thread overview]
Message-ID: <20150813123713.B897014064A@smtp.codeaurora.org> (raw)
In-Reply-To: <1438879591-2849-1-git-send-email-Jes.Sorensen@redhat.com>
> From: Jes Sorensen <Jes.Sorensen@redhat.com>
>
> alloc_orinocodev() would allocate the wiphy entry, but it would only get
> registered much later in orinoco_init(). If something failed in the init
> process inbetween the call to alloc_orinocodev() and the completion
> of orinoco_init(), the drivers would end up calling wiphy_unregister()
> with a NULL pointer causing beautiful OOPS fireworks.
>
> Explicitly call wiphy_unregister() instead in the right places.
>
> Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Thanks, applied to wireless-drivers-next.git.
Kalle Valo
prev parent reply other threads:[~2015-08-13 12:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-06 16:46 [PATCH] orinoco: Do not call wiphy_unregister() from free_orinocodev() Jes.Sorensen
2015-08-13 12:37 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150813123713.B897014064A@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=Jes.Sorensen@redhat.com \
--cc=linux-wireless@vger.kernel.org \
--cc=mahfouz.saif.elyazal@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).