From: Dan Carpenter <dan.carpenter@oracle.com>
To: Chandra S Gorentla <csgorentla@gmail.com>
Cc: gregkh@linuxfoundation.org, johnny.kim@atmel.com,
rachel.kim@atmel.com, dean.lee@atmel.com, chris.park@atmel.com,
linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: wilc1000: Process WARN, INFO options of debug levels from user
Date: Thu, 13 Aug 2015 22:08:45 +0300 [thread overview]
Message-ID: <20150813190844.GB4484@mwanda> (raw)
In-Reply-To: <1439400958-10454-1-git-send-email-csgorentla@gmail.com>
On Wed, Aug 12, 2015 at 11:05:58PM +0530, Chandra S Gorentla wrote:
> - if (copy_from_user(buffer, buf, count)) {
> + ret = simple_write_to_buffer(buffer, sizeof(buffer), ppos, buf, count);
This part doesn't make sense. Use copy_from_user(). Also it's not NUL
terminated so it leads to a read past the end of the array later. In
the original code, we just looked at the first char and didn't use
kstrtoint() so we didn't care about NUL termination.
regards,
dan carpenter
prev parent reply other threads:[~2015-08-13 19:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-12 17:35 [PATCH] staging: wilc1000: Process WARN, INFO options of debug levels from user Chandra S Gorentla
2015-08-13 19:08 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150813190844.GB4484@mwanda \
--to=dan.carpenter@oracle.com \
--cc=chris.park@atmel.com \
--cc=csgorentla@gmail.com \
--cc=dean.lee@atmel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=johnny.kim@atmel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=rachel.kim@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).