From: Dan Carpenter <dan.carpenter@oracle.com>
To: "Raphaël Beamonte" <raphael.beamonte@gmail.com>
Cc: Johnny Kim <johnny.kim@atmel.com>,
Rachel Kim <rachel.kim@atmel.com>, Dean Lee <dean.lee@atmel.com>,
Chris Park <chris.park@atmel.com>,
devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org,
linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH 1/3] staging: wilc1000: code style: fix macro with multiple statements
Date: Mon, 17 Aug 2015 12:08:52 +0300 [thread overview]
Message-ID: <20150817090828.GB5558@mwanda> (raw)
In-Reply-To: <641be2615e97db253a306c766a48c2afccf338d7.1439702894.git.raphael.beamonte@gmail.com>
On Sun, Aug 16, 2015 at 01:30:12AM -0400, Raphaël Beamonte wrote:
> #define MALLOC_WILC_BUFFER(name, size) \
> - exported_ ## name = kmalloc(size, GFP_KERNEL); \
> - if (!exported_ ## name) { \
> - printk("fail to alloc: %s memory\n", exported_ ## name); \
> - return -ENOBUFS; \
> - }
> + do { \
> + exported_ ## name = kmalloc(size, GFP_KERNEL); \
> + if (!exported_ ## name) { \
> + printk("fail to alloc: %s memory\n", exported_ ## name); \
> + return -ENOBUFS; \
> + }
> + } while (0)
Pull it in one indent level... But actually this macro has a return in
the middle of it, so it just introduces bugs all over the place like
eating cookies in bed. We should just delete it instead.
regards,
dan carpenter
next prev parent reply other threads:[~2015-08-17 9:08 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-16 5:30 [PATCH 0/3] staging: wilc1000: code style patches Raphaël Beamonte
2015-08-16 5:30 ` [PATCH 1/3] staging: wilc1000: code style: fix macro with multiple statements Raphaël Beamonte
2015-08-17 9:08 ` Dan Carpenter [this message]
2015-08-17 14:39 ` Raphaël Beamonte
2015-08-17 16:08 ` [PATCH 0/5] staging: wilc1000: code improvements Raphaël Beamonte
2015-08-17 16:08 ` [PATCH 1/5] staging: wilc1000: remove DECLARE_WILC_BUFFER() Raphaël Beamonte
2015-08-17 16:08 ` [PATCH 2/5] staging: wilc1000: remove FREE_WILC_BUFFER() Raphaël Beamonte
2015-08-17 17:42 ` Dan Carpenter
2015-08-17 16:08 ` [PATCH 3/5] staging: wilc1000: replace MALLOC_WILC_BUFFER() macro to avoid possible memory leak Raphaël Beamonte
2015-08-17 17:31 ` Dan Carpenter
2015-08-17 16:08 ` [PATCH 4/5] staging: wilc1000: use pr_* instead of printk Raphaël Beamonte
2015-08-17 17:47 ` Dan Carpenter
2015-08-17 17:59 ` Raphaël Beamonte
2015-08-17 18:06 ` Dan Carpenter
2015-08-17 16:08 ` [PATCH 5/5] staging: wilc1000: remove void function return statements that are not useful Raphaël Beamonte
2015-08-17 19:28 ` [PATCHv2 0/5] staging: wilc1000: code improvements Raphaël Beamonte
2015-08-17 19:28 ` [PATCHv2 1/5] staging: wilc1000: remove void function return statements that are not useful Raphaël Beamonte
2015-08-17 19:28 ` [PATCHv2 2/5] staging: wilc1000: use pr_* instead of printk Raphaël Beamonte
2015-08-17 19:55 ` Greg Kroah-Hartman
2015-08-17 23:06 ` [PATCHv3] staging: wilc1000: use netdev_* " Raphaël Beamonte
2015-08-18 4:24 ` Sudip Mukherjee
2015-08-18 5:27 ` Raphaël Beamonte
2015-08-18 6:10 ` Sudip Mukherjee
2015-08-19 2:58 ` Greg Kroah-Hartman
2015-08-17 19:28 ` [PATCHv2 3/5] staging: wilc1000: remove DECLARE_WILC_BUFFER() Raphaël Beamonte
2015-08-17 19:28 ` [PATCHv2 4/5] staging: wilc1000: remove FREE_WILC_BUFFER() Raphaël Beamonte
2015-08-17 20:01 ` Greg Kroah-Hartman
2015-08-17 19:28 ` [PATCHv2 5/5] staging: wilc1000: replace MALLOC_WILC_BUFFER() macro to avoid possible memory leak Raphaël Beamonte
2015-08-17 19:41 ` Arend van Spriel
2015-08-17 23:12 ` [PATCHv3] " Raphaël Beamonte
2015-08-17 23:46 ` Dan Carpenter
2015-08-18 9:15 ` Dan Carpenter
2015-08-18 17:06 ` Raphaël Beamonte
2015-08-19 2:59 ` Greg Kroah-Hartman
2015-08-19 3:14 ` [PATCHv4 0/2] staging: wilc1000: code improvements Raphaël Beamonte
2015-08-19 3:14 ` [PATCHv4 1/2] staging: wilc1000: remove FREE_WILC_BUFFER() Raphaël Beamonte
2015-09-03 1:19 ` Greg Kroah-Hartman
2015-09-05 16:25 ` Raphaël Beamonte
2015-09-05 16:29 ` Raphaël Beamonte
2015-08-19 3:14 ` [PATCHv4 2/2] staging: wilc1000: replace MALLOC_WILC_BUFFER() macro to avoid possible memory leak Raphaël Beamonte
2015-08-17 23:15 ` [PATCHv2 5/5] " Raphaël Beamonte
2015-08-16 5:30 ` [PATCH 2/3] staging: wilc1000: code style: fix globals initialized to false Raphaël Beamonte
2015-08-16 5:30 ` [PATCH 3/3] staging: wilc1000: code style: fix open brace { on wrong line Raphaël Beamonte
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150817090828.GB5558@mwanda \
--to=dan.carpenter@oracle.com \
--cc=chris.park@atmel.com \
--cc=dean.lee@atmel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=johnny.kim@atmel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=rachel.kim@atmel.com \
--cc=raphael.beamonte@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).