From: Greg KH <gregkh@linuxfoundation.org>
To: Chaehyun Lim <chaehyun.lim@gmail.com>
Cc: johnny.kim@atmel.com, rachel.kim@atmel.com, dean.lee@atmel.com,
chris.park@atmel.com, linux-wireless@vger.kernel.org,
devel@driverdev.osuosl.org
Subject: Re: [PATCH 4/4] staging: wilc1000: return -EINVAL for invalid argument checking
Date: Mon, 17 Aug 2015 12:53:12 -0700 [thread overview]
Message-ID: <20150817195312.GA6468@kroah.com> (raw)
In-Reply-To: <1439819071-30000-4-git-send-email-chaehyun.lim@gmail.com>
On Mon, Aug 17, 2015 at 10:44:31PM +0900, Chaehyun Lim wrote:
> This patch uses -EINVAL for invalid argument checking instead of using
> WILC_ERRORREPORT with WILC_INVALID_ARGUMENT.
>
> Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
> ---
> drivers/staging/wilc1000/wilc_msgqueue.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/wilc1000/wilc_msgqueue.c b/drivers/staging/wilc1000/wilc_msgqueue.c
> index dd87448..561ff88 100644
> --- a/drivers/staging/wilc1000/wilc_msgqueue.c
> +++ b/drivers/staging/wilc1000/wilc_msgqueue.c
> @@ -61,7 +61,7 @@ s32 WILC_MsgQueueSend(WILC_MsgQueueHandle *pHandle,
> Message *pstrMessage = NULL;
>
> if ((pHandle == NULL) || (u32SendBufferSize == 0) || (pvSendBuffer == NULL)) {
> - WILC_ERRORREPORT(s32RetStatus, WILC_INVALID_ARGUMENT);
> + return -EINVAL;
Watch out, WILC_ERRORREPORT has a goto in it, so I don't know if you can
always just do a "simple" return like this.
greg k-h
next prev parent reply other threads:[~2015-08-17 19:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-17 13:44 [PATCH 1/4] staging: wilc1000: delete wilc_log.h Chaehyun Lim
2015-08-17 13:44 ` [PATCH 2/4] staging: wilc1000: delete wilc_osconfig.h Chaehyun Lim
2015-08-17 19:52 ` Greg KH
2015-08-17 13:44 ` [PATCH 3/4] staging: wilc1000: remove WILC_ErrNo Chaehyun Lim
2015-08-17 14:23 ` Dan Carpenter
2015-08-17 13:44 ` [PATCH 4/4] staging: wilc1000: return -EINVAL for invalid argument checking Chaehyun Lim
2015-08-17 19:53 ` Greg KH [this message]
2015-08-17 19:51 ` [PATCH 1/4] staging: wilc1000: delete wilc_log.h Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150817195312.GA6468@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=chaehyun.lim@gmail.com \
--cc=chris.park@atmel.com \
--cc=dean.lee@atmel.com \
--cc=devel@driverdev.osuosl.org \
--cc=johnny.kim@atmel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=rachel.kim@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).