From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: "Raphaël Beamonte" <raphael.beamonte@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rachel Kim <rachel.kim@atmel.com>, Dean Lee <dean.lee@atmel.com>,
Chris Park <chris.park@atmel.com>,
devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org,
Johnny Kim <johnny.kim@atmel.com>,
linux-kernel@vger.kernel.org,
Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCHv3] staging: wilc1000: use netdev_* instead of printk
Date: Tue, 18 Aug 2015 11:40:50 +0530 [thread overview]
Message-ID: <20150818061050.GG2941@sudip-pc> (raw)
In-Reply-To: <CAE_Gge0YiZVQi66L3dNUoMg+W-K2KyJ0EJpgeia8=TJ57094QA@mail.gmail.com>
On Tue, Aug 18, 2015 at 01:27:31AM -0400, Raphaël Beamonte wrote:
> 2015-08-18 0:24 GMT-04:00 Sudip Mukherjee <sudipm.mukherjee@gmail.com>:
> >> + netdev_err("[Sendconfigpkt]Get Timed out\n");
> > This will not compile. you can not just replace printk with
> > netdev_*, you need to mention a net_device.
>
> You're right! I'm making a lot of mistakes. It seems I called the make
> command in the wrong git tree... Thanks for catching that, and taking
> time to review!
> I just saw there isn't any netdev_debug available. Do you know the
> reason for that? Is there a replacement besides pr_debug?
netdev_dbg
> Also, it seems that in all the functions where it's another netdev
> that's available that I could use, I don't have access to the
> net_device struct. Is there a general way to get that device
> information? I saw an old lkml post talking about dev_*() functions to
> do that? Would you have some hint on the matter?
If the function is not having the net_device try to see if you can
pass it the struct as an argument. if not possible then in any way then
no other way but to use pr_*
regards
sudip
next prev parent reply other threads:[~2015-08-18 6:10 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-16 5:30 [PATCH 0/3] staging: wilc1000: code style patches Raphaël Beamonte
2015-08-16 5:30 ` [PATCH 1/3] staging: wilc1000: code style: fix macro with multiple statements Raphaël Beamonte
2015-08-17 9:08 ` Dan Carpenter
2015-08-17 14:39 ` Raphaël Beamonte
2015-08-17 16:08 ` [PATCH 0/5] staging: wilc1000: code improvements Raphaël Beamonte
2015-08-17 16:08 ` [PATCH 1/5] staging: wilc1000: remove DECLARE_WILC_BUFFER() Raphaël Beamonte
2015-08-17 16:08 ` [PATCH 2/5] staging: wilc1000: remove FREE_WILC_BUFFER() Raphaël Beamonte
2015-08-17 17:42 ` Dan Carpenter
2015-08-17 16:08 ` [PATCH 3/5] staging: wilc1000: replace MALLOC_WILC_BUFFER() macro to avoid possible memory leak Raphaël Beamonte
2015-08-17 17:31 ` Dan Carpenter
2015-08-17 16:08 ` [PATCH 4/5] staging: wilc1000: use pr_* instead of printk Raphaël Beamonte
2015-08-17 17:47 ` Dan Carpenter
2015-08-17 17:59 ` Raphaël Beamonte
2015-08-17 18:06 ` Dan Carpenter
2015-08-17 16:08 ` [PATCH 5/5] staging: wilc1000: remove void function return statements that are not useful Raphaël Beamonte
2015-08-17 19:28 ` [PATCHv2 0/5] staging: wilc1000: code improvements Raphaël Beamonte
2015-08-17 19:28 ` [PATCHv2 1/5] staging: wilc1000: remove void function return statements that are not useful Raphaël Beamonte
2015-08-17 19:28 ` [PATCHv2 2/5] staging: wilc1000: use pr_* instead of printk Raphaël Beamonte
2015-08-17 19:55 ` Greg Kroah-Hartman
2015-08-17 23:06 ` [PATCHv3] staging: wilc1000: use netdev_* " Raphaël Beamonte
2015-08-18 4:24 ` Sudip Mukherjee
2015-08-18 5:27 ` Raphaël Beamonte
2015-08-18 6:10 ` Sudip Mukherjee [this message]
2015-08-19 2:58 ` Greg Kroah-Hartman
2015-08-17 19:28 ` [PATCHv2 3/5] staging: wilc1000: remove DECLARE_WILC_BUFFER() Raphaël Beamonte
2015-08-17 19:28 ` [PATCHv2 4/5] staging: wilc1000: remove FREE_WILC_BUFFER() Raphaël Beamonte
2015-08-17 20:01 ` Greg Kroah-Hartman
2015-08-17 19:28 ` [PATCHv2 5/5] staging: wilc1000: replace MALLOC_WILC_BUFFER() macro to avoid possible memory leak Raphaël Beamonte
2015-08-17 19:41 ` Arend van Spriel
2015-08-17 23:12 ` [PATCHv3] " Raphaël Beamonte
2015-08-17 23:46 ` Dan Carpenter
2015-08-18 9:15 ` Dan Carpenter
2015-08-18 17:06 ` Raphaël Beamonte
2015-08-19 2:59 ` Greg Kroah-Hartman
2015-08-19 3:14 ` [PATCHv4 0/2] staging: wilc1000: code improvements Raphaël Beamonte
2015-08-19 3:14 ` [PATCHv4 1/2] staging: wilc1000: remove FREE_WILC_BUFFER() Raphaël Beamonte
2015-09-03 1:19 ` Greg Kroah-Hartman
2015-09-05 16:25 ` Raphaël Beamonte
2015-09-05 16:29 ` Raphaël Beamonte
2015-08-19 3:14 ` [PATCHv4 2/2] staging: wilc1000: replace MALLOC_WILC_BUFFER() macro to avoid possible memory leak Raphaël Beamonte
2015-08-17 23:15 ` [PATCHv2 5/5] " Raphaël Beamonte
2015-08-16 5:30 ` [PATCH 2/3] staging: wilc1000: code style: fix globals initialized to false Raphaël Beamonte
2015-08-16 5:30 ` [PATCH 3/3] staging: wilc1000: code style: fix open brace { on wrong line Raphaël Beamonte
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150818061050.GG2941@sudip-pc \
--to=sudipm.mukherjee@gmail.com \
--cc=chris.park@atmel.com \
--cc=dan.carpenter@oracle.com \
--cc=dean.lee@atmel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=johnny.kim@atmel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=rachel.kim@atmel.com \
--cc=raphael.beamonte@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).